Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Verifier performance improvements. #92

Closed
rolfl opened this Issue · 0 comments

1 participant

@rolfl
Collaborator

Wilf (Canadian Wilf) has proposed changes to improve the performance of the Verifier. These should be considered/applied.

@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Performance of Verifier.
Initial commit with Byte-per-Character system for bitmask-based lookup tables.
See details at https://github.com/hunterhacker/jdom/wiki/Verifier-Performance
4ad684a
@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Verifie performance.
Change the bitmask to not contain ':' as part of the valid name characters.
Also improve the performance test to average the best times.
Centralize the JDOM Name checking to  anew method.
6ac519b
@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Verifier performance
Use byte-based arithmatic everywhere.
23184fb
@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Improve performance of checkCharacterData ...
restructured loop is much faster (runs in half the time).
Add check in to VerifierBuilder to confirm logic about CharacterData being a superset of other character roles.
45f87c3
@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Update the performance benchmark tool to:
- delay for 5 seconds to allow a  profiler tool to be attached.
- run 200 iterations, of which the best 50 are reported.
- report the average time for each loop rather than the sum time.
6886a09
@rolfl rolfl closed this issue from a commit
@rolfl rolfl Fixes #92 - Performance improvements in Verifier.
Attribution for Wilf's contributions. Close off the issue.
73c5682
@rolfl rolfl closed this in 73c5682
@rolfl rolfl referenced this issue from a commit
@rolfl rolfl Issue #92 - Fix off-by-one bug introduced in character verification.
The code will now verify the second character in a name.
Additionally, the error messages for broken names has been improved to indicate what both the broken name and character are, instead of just the character.
Also, change the checkNamespacePrefix code to leverage the common code from checkElementName and checkAttributeName.

Also improve the test harness to cover test cases that are now more complicated because the name-check code is in two places now instead of one....
d72596e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.