New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier performance improvements. #92

Closed
rolfl opened this Issue Sep 2, 2012 · 0 comments

Comments

Projects
None yet
1 participant
@rolfl
Collaborator

rolfl commented Sep 2, 2012

Wilf (Canadian Wilf) has proposed changes to improve the performance of the Verifier. These should be considered/applied.

rolfl added a commit that referenced this issue Sep 2, 2012

Issue #92 - Performance of Verifier.
Initial commit with Byte-per-Character system for bitmask-based lookup tables.
See details at https://github.com/hunterhacker/jdom/wiki/Verifier-Performance

rolfl added a commit that referenced this issue Sep 3, 2012

Issue #92 - Verifie performance.
Change the bitmask to not contain ':' as part of the valid name characters.
Also improve the performance test to average the best times.
Centralize the JDOM Name checking to  anew method.

rolfl added a commit that referenced this issue Sep 3, 2012

Issue #92 - Verifier performance
Use byte-based arithmatic everywhere.

rolfl added a commit that referenced this issue Sep 3, 2012

Issue #92 - Improve performance of checkCharacterData ...
restructured loop is much faster (runs in half the time).
Add check in to VerifierBuilder to confirm logic about CharacterData being a superset of other character roles.

rolfl added a commit that referenced this issue Sep 3, 2012

Issue #92 - Update the performance benchmark tool to:
- delay for 5 seconds to allow a  profiler tool to be attached.
- run 200 iterations, of which the best 50 are reported.
- report the average time for each loop rather than the sum time.

@rolfl rolfl closed this in 73c5682 Sep 3, 2012

rolfl added a commit that referenced this issue Sep 9, 2012

Issue #92 - Fix off-by-one bug introduced in character verification.
The code will now verify the second character in a name.
Additionally, the error messages for broken names has been improved to indicate what both the broken name and character are, instead of just the character.
Also, change the checkNamespacePrefix code to leverage the common code from checkElementName and checkAttributeName.

Also improve the test harness to cover test cases that are now more complicated because the name-check code is in two places now instead of one....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment