New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented API for manipulating Message Expiration #16

Merged
merged 2 commits into from Aug 7, 2015

Conversation

Projects
None yet
2 participants
@Akamaozu
Contributor

Akamaozu commented Aug 7, 2015

Just a simple doc update.

Also needed to add the note on using undefined to keep messages from expiring. I tried a blank string, -1 and something else before I found out what was needed.

@Akamaozu

This comment has been minimized.

Show comment
Hide comment
@Akamaozu

Akamaozu Aug 7, 2015

Contributor

Case in point ...

@esotericmynd's latest updates to his fork is to keep messages from expiring by default.
https://github.com/esotericmynd/jackrabbit/commit/b0d5762e35a334f3e752767b8fb3f9245fb41a27

@stephengardner commented out the line with the expiry timer in his fork, to accomplish the same thing.
stephengardner@d5b34f0

If the default here isn't non-expiring messages, it would be nice to indicate clearly in the docs how to do so.

Contributor

Akamaozu commented Aug 7, 2015

Case in point ...

@esotericmynd's latest updates to his fork is to keep messages from expiring by default.
https://github.com/esotericmynd/jackrabbit/commit/b0d5762e35a334f3e752767b8fb3f9245fb41a27

@stephengardner commented out the line with the expiry timer in his fork, to accomplish the same thing.
stephengardner@d5b34f0

If the default here isn't non-expiring messages, it would be nice to indicate clearly in the docs how to do so.

hunterloftis added a commit that referenced this pull request Aug 7, 2015

Merge pull request #16 from Akamaozu/messageTtl-docs-update
Documented New API for Manipulating Message Expiration

@hunterloftis hunterloftis merged commit 1c74ec0 into hunterloftis:master Aug 7, 2015

@Akamaozu Akamaozu changed the title from Documented New API for Manipulating Message Expiration to Documented new API for manipulating Message Expiration Aug 7, 2015

@Akamaozu Akamaozu changed the title from Documented new API for manipulating Message Expiration to Documented API for manipulating Message Expiration Aug 7, 2015

@Akamaozu Akamaozu deleted the Akamaozu:messageTtl-docs-update branch Aug 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment