Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jul 28, 2011
  1. @alexandresalome
  2. @alexandresalome

    [HttpKernel] CS in file storage

    alexandresalome authored committed
  3. @alexandresalome
  4. @alexandresalome
  5. @alexandresalome
  6. @alexandresalome
  7. @alexandresalome
  8. @alexandresalome
  9. @alexandresalome
  10. @alexandresalome

    Add POC for file storage system

    alexandresalome authored committed
Commits on Jul 27, 2011
  1. Updated Persian translation

    authored
Commits on Jul 26, 2011
  1. @fabpot

    merged branch jdreesen/fix-02 (PR #1814)

    fabpot authored
    Commits
    -------
    
    b6ff4d8 [FrameworkBundle] Updated German validator translation
    
    Discussion
    ----------
    
    [FrameworkBundle] Updated German validator translation
  2. @jdreesen
  3. @fabpot

    merged branch fatganz/master (PR #1812)

    fabpot authored
    Commits
    -------
    
    6d56f74 Fixed typo in ukrainian validator messages translation
    
    Discussion
    ----------
    
    Updated Ukrainian validator translation
    
    Fixed typo in Ukrainian validator messages translation
  4. Fixed typo in ukrainian validator messages translation

    Rostyslav Kinash authored
  5. @fabpot

    merged branch fatganz/master (PR #1811)

    fabpot authored
    Commits
    -------
    
    5d6ec70 Added ukrainian validator transaltions
    
    Discussion
    ----------
    
    Ukrainian validator messages
    
    Added Ukrainian translation for validator messages
  6. Added ukrainian validator transaltions

    Rostyslav Kinash authored
  7. @fabpot

    merged branch elliot/issue-1768-expected-alias (PR #1807)

    fabpot authored
    Commits
    -------
    
    d664f5f Changed the wording of the exception thrown when Bundle::getAlias() returns something different to the Container::underscore version, fixes #1768
    
    Discussion
    ----------
    
    Changed exception wording
    
    Changed the wording of the exception thrown when Bundle::getAlias() returns something different to the Container::underscore version, fixes #1768
  8. @elliot

    Changed the wording of the exception thrown when Bundle::getAlias() r…

    elliot authored
    …eturns something different to the Container::underscore version, fixes #1768
  9. @fabpot
  10. @fabpot
  11. @fabpot

    merged branch aboks/event_trace (PR #1786)

    fabpot authored
    Commits
    -------
    
    9d8e6f6 [FrameworkBundle] Changed TraceableEventDispatcher to log calls to event listeners _before_ actually calling them
    
    Discussion
    ----------
    
    [FrameworkBundle] Log calls to event listereners _before_ calling them
    
    The current implementation of `TraceableEventDispatcher` logs calls to event listeners _after_ actually calling them. This leads to strange logs when an event listener triggers another event.
    
    For example, if I attach some `LoginListener` to the `security.interactive_login`-event, the log will look something like this:
    <pre>
    ...
    User "myusername" has been authenticated successfully
    Notified event "security.interactive_login" to listener "MyVendor\MyBundle\EventListener\LoginListener::onSecurityInteractiveLogin".
    Notified event "kernel.request" to listener "Symfony\Component\Security\Http\Firewall::onKernelRequest".
    ...
    </pre>
    From the logs it looks like the `kernel.request` event was fired after the user was authenticated, whereas it was actually the listener to `kernel.request` that caused the user to be authenticated.
    
    By logging the call to the event listener _before_ calling it, the logs will look like this:
    <pre>
    ...
    Notified event "kernel.request" to listener "Symfony\Component\Security\Http\Firewall::onKernelRequest".
    Notified event "security.interactive_login" to listener "MyVendor\MyBundle\EventListener\LoginListener::onSecurityInteractiveLogin".
    User "myusername" has been authenticated successfully
    ...
    </pre>
    In my opinion this makes the causal relationship between the events clearer.
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/07/24 11:18:48 -0700
    
    :+1: for this.
  12. @fabpot

    merged branch snc/patch-1 (PR #1790)

    fabpot authored
    Commits
    -------
    
    5219f81 Using the $status parameter instead of fixed value when creating a RedirectResponse.
    
    Discussion
    ----------
    
    Using the $status parameter instead of fixed value
    
    I checked the usages and the optional `$status` parameter is never used, so maybe another option would be to remove the parameter completely...
    
    ---------------------------------------------------------------------------
    
    by jaugustin at 2011/07/25 03:11:00 -0700
    
    maybe you could test that $status is a valid redirect code
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/07/25 04:40:21 -0700
    
    @jaugustin This check is already included in `RedirectResponse` class.
  13. @fabpot
  14. @fabpot

    merged branch sasezaki/BrowserKit_useragent (PR #1789)

    fabpot authored
    Commits
    -------
    
    266e60e Don't tell a lie to every WebServers
    
    Discussion
    ----------
    
    Please don't tell a lie to every WebServers
    
    Fake Useragent name should be only in test case .
  15. @fabpot

    merged branch stloyd/patch-6 (PR #1800)

    fabpot authored
    Commits
    -------
    
    03bd20f FrameworkExtension - Remove unused variable
    
    Discussion
    ----------
    
    FrameworkExtension - Remove unused variable
  16. @fabpot

    merged branch 1ed/hungarian-validator-messages (PR #1803)

    fabpot authored
    Commits
    -------
    
    987eb54 [FrameworkBundle] updated hungarian validator messages
    
    Discussion
    ----------
    
    [FrameworkBundle] updated hungarian validator messages
  17. @fabpot

    [Routing] changed UrlGeneratorInterface::generate() signature to allo…

    fabpot authored
    …w passing objects instead of arrays
Commits on Jul 25, 2011
  1. @1ed
  2. @stloyd
  3. @fabpot
  4. @fabpot

    merged branch schmittjoh/cookieFix (PR #1793)

    fabpot authored
    Commits
    -------
    
    0b3ff39 fix supported cookie date formats
    
    Discussion
    ----------
    
    fix supported cookie date formats
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/07/24 13:16:25 -0700
    
    :+1: as the current behavior breaks the crawling of some sites using Goutte (``bit.ly`` for instance)
  5. @fabpot

    added a CONTRIBUTORS file

    fabpot authored
Commits on Jul 24, 2011
  1. @schmittjoh
Something went wrong with that request. Please try again.