Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed alignment bug #1 #3

Merged
merged 1 commit into from Oct 29, 2019
Merged

Conversation

@eekbatani
Copy link

eekbatani commented Oct 28, 2019

Hi, I managed to fix issue #1 about misaligned items by overriding the styling conflicts from bootstrap and the other style sheet libraries with a custom design in the styles.css file.

Since there is no way to predict the dimensions of the image ahead of time, I used a "max-height" CSS property to cap the height of the images in the thumbnails to 150 pixels. This way all the images should appear at a uniform height and thus always be aligned.

@husseinfahmy husseinfahmy merged commit a396bac into husseinfahmy:master Oct 29, 2019
@husseinfahmy

This comment has been minimized.

Copy link
Owner

husseinfahmy commented Oct 29, 2019

Thanks Ehsan, the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.