Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker support. #38

Merged
merged 3 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@wi1dcard
Copy link
Contributor

wi1dcard commented Feb 24, 2019

写一下 Dockerfile,如果能放到 Docker Hub 是再好不过了,可以直接给 Dockerized CI/CD 使用。

Show resolved Hide resolved .dockerignore Outdated
@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 26, 2019

@hustcc 需要你注册一下 Docker Hub 并创建 Repo,然后关联到 GitHub 的该 Repo 上,这样就能自动构建了。

Show resolved Hide resolved README.md Outdated
@hustcc

This comment has been minimized.

Copy link
Owner

hustcc commented Feb 26, 2019

Readme 里面,可以专门加一个做 docker 的使用,和 ci 集成 平级。不要分散到 Readme 的各个地方吧~~

@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 26, 2019

Readme 里面,可以专门加一个做 docker 的使用,和 ci 集成 平级。不要分散到 Readme 的各个地方吧~~

Docker 也不一定非是单独,场景挺多的。

@hustcc

This comment has been minimized.

Copy link
Owner

hustcc commented Feb 26, 2019

刚发现 docker hub 上 我的 id 被占用了,囧~

@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 26, 2019

哈哈哈,那就注册个别的吧,我给改一下。

@hustcc

This comment has been minimized.

Copy link
Owner

hustcc commented Feb 27, 2019

yuque/lint-md

@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 27, 2019

@hustcc 已提交。

@hustcc hustcc merged commit 1fa10c4 into hustcc:master Feb 27, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.297%
Details
security/snyk - package.json (hustcc) No manifest changes detected
@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 27, 2019

@hustcc 阿里语雀的作者是你吗大佬😂

@hustcc

This comment has been minimized.

Copy link
Owner

hustcc commented Feb 27, 2019

其实不是,哈哈😄

@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 27, 2019

@hustcc 2333,刚确认了一下,镜像已经可用了。

@hustcc

This comment has been minimized.

Copy link
Owner

hustcc commented Feb 28, 2019

travis 不能使用镜像的方式吗?我看 readme 没有提到。

@wi1dcard

This comment has been minimized.

Copy link
Contributor Author

wi1dcard commented Feb 28, 2019

travis 不能使用镜像的方式吗?我看 readme 没有提到。

是的,Travis 之前是有支持 Docker-based build environment 的,后来因为维护太困难就切成全部虚拟机了,好像就是 18 年底的事儿。所以现在 Travis 我认为他们给自己的定位就是简单、易配置的小项目 CI 平台。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.