Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot initialize Vault using recovery shares #416

Closed
derek-pryor opened this issue Mar 30, 2019 · 2 comments

Comments

@derek-pryor
Copy link

commented Mar 30, 2019

When initializing a Vault deployment configured with a seal stanza you are required to specify the recovery_shares and recovery_threshold values. The current logic make it impossible to initialize Vault in this configuration, as the code path the passes library's the argument checking logic will fail Vault's argument checking logic.

Current argument checking logic: if recovery_threshold <= recovery_shares:
Needed argument checking logic: if recovery_threshold > recovery_shares:

This logic bug was fixed in f8b7842 but was explicitly reintroduced in e363738

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Mar 31, 2019

Yup looks like my bad. I'll release a patch version shortly with the correct logic in place asap.

@derek-pryor

This comment has been minimized.

Copy link
Author

commented Apr 1, 2019

Thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.