Skip to content

docs: make OIDC Authorization URL Request example work again. #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2023
Merged

docs: make OIDC Authorization URL Request example work again. #1010

merged 1 commit into from
Jun 24, 2023

Conversation

robbat2
Copy link
Contributor

@robbat2 robbat2 commented Jun 20, 2023

  • Import urllib.parse so parse works.
  • Document how this interacts with OIDC allowed_redirect_uris & roles.
  • Python used a return outside of any function, add a main() function to keep the code clean.
  • Fix odic mis-spelling.
  • Add a nicer HTML redirect page

Signed-off-by: Robin H. Johnson rjohnson@coreweave.com

@robbat2 robbat2 requested a review from a team as a code owner June 20, 2023 19:00
@briantist briantist added documentation documentation updates and/or requests for expanded documentation auth methods generally related to a Vault auth method jwt/oidc JWT/OIDC auth method labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #1010 (6e30b67) into main (3b4e5ca) will decrease coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   83.59%   81.95%   -1.64%     
==========================================
  Files          65       65              
  Lines        3023     3026       +3     
==========================================
- Hits         2527     2480      -47     
- Misses        496      546      +50

see 3 files with indirect coverage changes

briantist
briantist previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robbat2 , welcome! Thanks for submitting this improvement to our docs. I've left an optional inline comment but this otherwise looks great!

@briantist briantist self-assigned this Jun 21, 2023
@briantist briantist added this to the 1.2.0 milestone Jun 21, 2023
@robbat2
docs: make OIDC Authorization URL Request example work again.
6e30b67 
- Import `urllib.parse` so parse works.
- Document how this interacts with OIDC allowed_redirect_uris & roles.
- Python used a `return` outside of any function, add a `main()`
  function to keep the code clean.
- Fix `odic` mis-spelling.
- Add a nicer HTML redirect page

Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
briantist
briantist approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbat2 thanks again for updating these docs!

If you haven't seen this yet, we're actively looking for more contributors; we'd love to see more if you're interested and able:

@briantist briantist merged commit b29291d into hvac:main Jun 24, 2023
@briantist briantist linked an issue Jun 24, 2023 that may be closed by this pull request
OIDC Authorization Example Issue #788
Closed
@briantist briantist mentioned this pull request Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
auth methods generally related to a Vault auth method documentation documentation updates and/or requests for expanded documentation jwt/oidc JWT/OIDC auth method
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

OIDC Authorization Example Issue
2 participants
@robbat2 @briantist