Skip to content

add tests and docs to sdist, improve build testing #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

briantist
Copy link
Contributor

  • update build tests
    • test both wheel and sdist installation
    • upload the build artifacts to CI run so they can be downloaded by interested parties
  • set sdist to include tests and docs, resolves Add tests to pypi tarball #1011

@briantist briantist added CI/CD related to CI/CD (not necessarily tests) meta related to meta-discussions around this module / project tests related to tests (not necessarily CI/CD) labels Jun 25, 2023
@briantist briantist added this to the 1.2.0 milestone Jun 25, 2023
@briantist briantist self-assigned this Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1015 (c5969dc) into main (3d6f98d) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
+ Coverage   81.78%   81.95%   +0.17%     
==========================================
  Files          65       65              
  Lines        2992     3026      +34     
==========================================
+ Hits         2447     2480      +33     
- Misses        545      546       +1     

see 8 files with indirect coverage changes

@briantist briantist marked this pull request as ready for review June 25, 2023 02:50
@briantist briantist requested a review from a team as a code owner June 25, 2023 02:50
@briantist
Copy link
Contributor Author

Hi @asagratini this PR adds the tests (and also docs) to the sdist tarball. I also updated our CI so that it uploads build artifacts for all the build tests, so you can actually download the dist files for those CI runs now and ensure that they will work for you packaging needs.

For example, here's the latest run as of this writing, and you should be able to download any of the artifacts listed (they should all be the same even though they are generated on different platforms):

If you could let me know that it meets your needs I would appreciate it. The 1.2.0 release is probably going to be the last before 2.0.0 and I'd like to get this in before the next major version.

@briantist
Copy link
Contributor Author

Hi @asagratini , just checking in one more time to see if you can confirm this will meet your packaging needs.

@asagrati
Copy link

Hi @asagratini , just checking in one more time to see if you can confirm this will meet your packaging needs.

Hi @briantist, yes, it looks good, thank you!

@briantist briantist merged commit f58d1a2 into hvac:main Jun 27, 2023
@briantist briantist deleted the build/sdist-tests-docs branch June 27, 2023 19:27
@briantist briantist added the misc Used as a release-drafter "category" label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD related to CI/CD (not necessarily tests) meta related to meta-discussions around this module / project misc Used as a release-drafter "category" tests related to tests (not necessarily CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to pypi tarball
3 participants