-
Notifications
You must be signed in to change notification settings - Fork 393
add tests and docs to sdist, improve build testing #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
briantist
commented
Jun 25, 2023
- update build tests
- test both wheel and sdist installation
- upload the build artifacts to CI run so they can be downloaded by interested parties
- set sdist to include tests and docs, resolves Add tests to pypi tarball #1011
Codecov Report
@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 81.78% 81.95% +0.17%
==========================================
Files 65 65
Lines 2992 3026 +34
==========================================
+ Hits 2447 2480 +33
- Misses 545 546 +1 |
Hi @asagratini this PR adds the tests (and also docs) to the sdist tarball. I also updated our CI so that it uploads build artifacts for all the build tests, so you can actually download the dist files for those CI runs now and ensure that they will work for you packaging needs. For example, here's the latest run as of this writing, and you should be able to download any of the artifacts listed (they should all be the same even though they are generated on different platforms): If you could let me know that it meets your needs I would appreciate it. The 1.2.0 release is probably going to be the last before 2.0.0 and I'd like to get this in before the next major version. |
Hi @asagratini , just checking in one more time to see if you can confirm this will meet your packaging needs. |
Hi @briantist, yes, it looks good, thank you! |