-
Notifications
You must be signed in to change notification settings - Fork 393
Add alias_name_source for Kubernetes Auth create_role #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
=======================================
Coverage 84.99% 85.00%
=======================================
Files 65 65
Lines 3133 3135 +2
=======================================
+ Hits 2663 2665 +2
Misses 470 470
|
Hi @michael-diggin welcome and thanks for putting this up! I made two small suggestions but it otherwise looks good. I'm trying to get |
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Hi @briantist, thanks for the quick review! I've accepted both suggestions and it would be great to get this into v1.2.0! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed one, will commit it for expediency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-diggin looks great! thanks very much for adding tests as well. Hope you might stick around with more contributions if you're able, we're actively seeking help on the project. Cheers!
For the Kubernetes auth method, Vault's create role API endpoint accepts
alias_name_source
as part of the payload (https://developer.hashicorp.com/vault/api-docs/auth/kubernetes#alias_name_source). This PR adds that as an optional argument to thecreate_role
python method. Defaults to not set so no change to existing behaviour (as this param was only added in Vault 1.9)