Skip to content

Add support to PKI class to perform CRUD on issuers #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add support to PKI class to perform CRUD on issuers #1102

merged 2 commits into from
Oct 30, 2023

Conversation

tot19
Copy link
Contributor

@tot19 tot19 commented Oct 28, 2023 •
edited by briantist
Loading

Resolves #1098

@tot19 tot19 requested a review from a team as a code owner October 28, 2023 12:56
@briantist briantist self-assigned this Oct 29, 2023
@briantist briantist added enhancement a new feature or addition documentation documentation updates and/or requests for expanded documentation secrets engines generally related to a Vault secrets engine minor Used as part of release-drafter's version-resolver configuration pki Related to the PKI secrets engine labels Oct 29, 2023
@briantist briantist added this to the 2.1.0 milestone Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #1102 (8a19dca) into main (f57cc04) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   87.09%   87.16%   +0.06%     
==========================================
  Files          64       64              
  Lines        3146     3162      +16     
==========================================
+ Hits         2740     2756      +16     
  Misses        406      406
Files Coverage Δ
hvac/api/secrets_engines/pki.py 100.00% <100.00%> (ø)

briantist
briantist reviewed Oct 29, 2023
View reviewed changes
hvac/api/secrets_engines/pki.py Outdated
Comment on lines 820 to 821
if extra_params is None:
extra_params = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not covered by tests, but I think we can remove this conditional completely. json=None should work ok without us needing to convert it to {}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it!

@briantist briantist added the hacktoberfest-accepted PR is accepted for hacktoberfest label Oct 30, 2023
briantist
briantist approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@briantist briantist merged commit ede8622 into hvac:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
documentation documentation updates and/or requests for expanded documentation enhancement a new feature or addition hacktoberfest-accepted PR is accepted for hacktoberfest minor Used as part of release-drafter's version-resolver configuration pki Related to the PKI secrets engine secrets engines generally related to a Vault secrets engine
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Add support to PKI class to perform CRUD on issuers
2 participants
@tot19 @briantist