Skip to content

update the KV documentation #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

briantist
Copy link
Contributor

Fixes #1113

Fixes some mistakes the documentation from its inception and then the subsequent removal of the Client.kv member:

@briantist briantist added documentation documentation updates and/or requests for expanded documentation secrets engines generally related to a Vault secrets engine kv Key/Value (KV) secrets engine maintenance General technical debt labels Dec 30, 2023
@briantist briantist added this to the 2.1.0 milestone Dec 30, 2023
@briantist briantist self-assigned this Dec 30, 2023
@briantist briantist requested a review from a team as a code owner December 30, 2023 23:16
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd2539b) 87.38% compared to head (e2d30bd) 87.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          66       66           
  Lines        3227     3227           
=======================================
  Hits         2820     2820           
  Misses        407      407           

@briantist briantist added the patch Used as part of release-drafter's version-resolver configuration label Dec 30, 2023
@briantist briantist closed this Dec 30, 2023
@briantist briantist reopened this Dec 30, 2023
@briantist briantist merged commit 26bb929 into hvac:main Dec 30, 2023
@briantist briantist deleted the docs/old-reference branch December 30, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation updates and/or requests for expanded documentation kv Key/Value (KV) secrets engine maintenance General technical debt patch Used as part of release-drafter's version-resolver configuration secrets engines generally related to a Vault secrets engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update client.kv.default_kv_version in doc
1 participant