Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policy rules fetching from json #254

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@seuf
Copy link
Contributor

commented Aug 30, 2018

Since a few version of Hashicorp Vault, the policy rules are returned inside a data object in the json.
This PR add a test if rules is present at the root of the json. Else it fetch rules from the data.rules.

Related issue : TerryHowe/ansible-modules-hashivault#81

TS227FFN
@codecov-io

This comment has been minimized.

Copy link

commented Aug 30, 2018

Codecov Report

Merging #254 into master will increase coverage by 0.42%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   88.56%   88.98%   +0.42%     
==========================================
  Files          12       12              
  Lines        1014     1017       +3     
==========================================
+ Hits          898      905       +7     
+ Misses        116      112       -4
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.63% <75%> (+0.06%) ⬆️
hvac/utils.py 78.94% <0%> (+10.52%) ⬆️
@drewmullen

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

Thanks @seuf this has fixed the policy issue! great work!

@Dudesons

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

@drewmullen There is an ETA for a new release with this code ?

@drewmullen drewmullen referenced this pull request Aug 31, 2018

Closed

Vault Secret Engine 2 #82

@jeffwecan jeffwecan merged commit 8f63b53 into hvac:master Aug 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2018

@Dudesons I'm hoping to include this change in hvac v0.6.4 that is intended to be released by Monday, September 3rd (ideally).

@jeffwecan jeffwecan added this to the 0.6.4 milestone Aug 31, 2018

@Dudesons

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

@jeffwecan great :)

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2018

Quick update on the release front: Intended date slipped a bit. Planning on cutting the 0.6.4 release with this change later this afternoon/evening pending this PR being merged in: #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.