Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kv classes #257

Merged
merged 7 commits into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@jeffwecan
Copy link
Collaborator

commented Aug 31, 2018

Starting to add in some kv-related classes in preparation for more robust kv version 2 support.

I am especially keen to get your feedback on the pattern being set up in the Kv class (meant to be a wrapper to make it easier to default to one kv secret engine version or another across the board) @dbwpe.

@jeffwecan jeffwecan added this to the 0.6.4 milestone Aug 31, 2018

@jeffwecan jeffwecan requested a review from dbwpe Aug 31, 2018

@jeffwecan jeffwecan force-pushed the jeffwecan:new_kv_classes branch from e90064c to 7c820f6 Aug 31, 2018

@jeffwecan jeffwecan force-pushed the jeffwecan:new_kv_classes branch from 7c820f6 to a874dee Aug 31, 2018

@jeffwecan jeffwecan force-pushed the jeffwecan:new_kv_classes branch from a874dee to 2e8715a Aug 31, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Aug 31, 2018

Codecov Report

Merging #257 into master will increase coverage by 0.67%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   88.49%   89.16%   +0.67%     
==========================================
  Files          12       15       +3     
  Lines        1017     1080      +63     
==========================================
+ Hits          900      963      +63     
  Misses        117      117
Impacted Files Coverage Δ
hvac/api/__init__.py 100% <100%> (ø) ⬆️
hvac/v1/__init__.py 85.55% <100%> (+0.06%) ⬆️
hvac/api/secrets_engines/__init__.py 100% <100%> (ø)
hvac/api/secrets_engines/kv.py 100% <100%> (ø)
hvac/api/secrets_engines/kv_v1.py 100% <100%> (ø)

jeffwecan added some commits Aug 31, 2018

@jeffwecan jeffwecan merged commit 5f92583 into hvac:master Aug 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan deleted the jeffwecan:new_kv_classes branch Aug 31, 2018

@jeffwecan jeffwecan referenced this pull request Sep 4, 2018

Merged

New kv classes v2 #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.