Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kv classes v2 #260

Merged
merged 8 commits into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@jeffwecan
Copy link
Collaborator

commented Sep 4, 2018

Second bit of KV changes started with #257. Building on the changes in that PR, this changeset adds support for version 2 of the KV secret engine.

jeffwecan added some commits Sep 4, 2018

@jeffwecan jeffwecan requested a review from dbwpe Sep 4, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Sep 4, 2018

Codecov Report

Merging #260 into master will increase coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #260      +/-   ##
=========================================
+ Coverage   89.16%   89.9%   +0.73%     
=========================================
  Files          15      16       +1     
  Lines        1080    1159      +79     
=========================================
+ Hits          963    1042      +79     
  Misses        117     117
Impacted Files Coverage Δ
hvac/api/secrets_engines/kv_v1.py 100% <ø> (ø) ⬆️
hvac/v1/__init__.py 85.55% <ø> (ø) ⬆️
hvac/api/secrets_engines/kv_v2.py 100% <100%> (ø)
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/kv.py 100% <100%> (ø) ⬆️

jeffwecan added some commits Sep 5, 2018

@jeffwecan jeffwecan added this to the 0.6.4 milestone Sep 5, 2018

@jeffwecan jeffwecan referenced this pull request Sep 5, 2018

Closed

Kvv2 support #216

@jeffwecan jeffwecan merged commit 1148337 into hvac:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan deleted the jeffwecan:new_kv_classes_v2 branch Sep 5, 2018

@jeffwecan

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 5, 2018

Note: meant to close #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.