Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces #268

Merged
merged 7 commits into from Sep 19, 2018

Conversation

@tiny-dancer
Copy link
Contributor

commented Sep 18, 2018

#265

@stenio123 was taking too long :)

version Outdated
@@ -1 +1 @@
0.6.4
0.6.5

This comment has been minimized.

Copy link
@jeffwecan

jeffwecan Sep 18, 2018

Collaborator

I missed that this change was made on this initial PR's commit. Would you mind getting it reverted @tiny-dancer? Pending that I see no reason we can't get this merged in. (FWIW, I am intending for a few other changes to go out in the 0.6.5 release that is tentatively slated for Oct. 1st.)

tiny-dancer added some commits Sep 18, 2018

@tiny-dancer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

@jeffwecan updated

hvac/v1/__init__.py Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

commented Sep 18, 2018

Codecov Report

Merging #268 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #268      +/-   ##
=========================================
- Coverage   89.96%   89.9%   -0.06%     
=========================================
  Files          16      16              
  Lines        1166    1169       +3     
=========================================
+ Hits         1049    1051       +2     
- Misses        117     118       +1
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.55% <ø> (ø) ⬆️
hvac/adapters.py 95.52% <66.66%> (-1.36%) ⬇️
@tiny-dancer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

@jeffwecan updated

@codecov-io

This comment has been minimized.

Copy link

commented Sep 18, 2018

Codecov Report

Merging #268 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #268      +/-   ##
=========================================
- Coverage   89.96%   89.9%   -0.06%     
=========================================
  Files          16      16              
  Lines        1166    1169       +3     
=========================================
+ Hits         1049    1051       +2     
- Misses        117     118       +1
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.55% <ø> (ø) ⬆️
hvac/adapters.py 95.52% <66.66%> (-1.36%) ⬇️
2 similar comments
@codecov-io

This comment has been minimized.

Copy link

commented Sep 18, 2018

Codecov Report

Merging #268 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #268      +/-   ##
=========================================
- Coverage   89.96%   89.9%   -0.06%     
=========================================
  Files          16      16              
  Lines        1166    1169       +3     
=========================================
+ Hits         1049    1051       +2     
- Misses        117     118       +1
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.55% <ø> (ø) ⬆️
hvac/adapters.py 95.52% <66.66%> (-1.36%) ⬇️
@codecov-io

This comment has been minimized.

Copy link

commented Sep 18, 2018

Codecov Report

Merging #268 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #268      +/-   ##
=========================================
- Coverage   89.96%   89.9%   -0.06%     
=========================================
  Files          16      16              
  Lines        1166    1169       +3     
=========================================
+ Hits         1049    1051       +2     
- Misses        117     118       +1
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.55% <ø> (ø) ⬆️
hvac/adapters.py 95.52% <66.66%> (-1.36%) ⬇️
@jeffwecan
Copy link
Collaborator

left a comment

Perfect 👌

Thanks for getting this finalized!

@jeffwecan jeffwecan merged commit 1c2deb5 into hvac:master Sep 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan modified the milestones: 0.7.0, 0.6.5 Sep 19, 2018

@tiny-dancer tiny-dancer deleted the tiny-dancer:namespaces branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.