Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] identity secrets engine #269

Merged
merged 20 commits into from Oct 31, 2018

Conversation

@tiny-dancer
Copy link
Contributor

commented Sep 19, 2018

opening for visibility, still a WIP and verifying.

https://www.vaultproject.io/api/secret/identity/index.html

TODO:

  • Entity
  • Entity Alias
  • Lookup
  • documentation
  • tests

Out of Scope:

  • Group
  • Group Alias

stenio123 and others added some commits Sep 12, 2018

mg
mg
@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2018

I know this is still a work-in-progress, but just wanted to call out that it would be nice to get some usage information for http://hvac.readthedocs.io/ as outlined in https://github.com/hvac/hvac/blob/master/CONTRIBUTING.md#examples whenever you get to that point. 👍

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2018

Oh and do you think you'll have time to wrap up the changes in this PR over the next week or so? (If so, I'll tag it for the 0.6.5 milestone.)

@tiny-dancer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

over the next week or so

yup that should work!

@codecov-io

This comment has been minimized.

Copy link

commented Sep 19, 2018

Codecov Report

Merging #269 into master will increase coverage by 0.01%.
The diff coverage is 90.73%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   90.64%   90.65%   +0.01%     
==========================================
  Files          39       41       +2     
  Lines        1893     2152     +259     
==========================================
+ Hits         1716     1951     +235     
- Misses        177      201      +24
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/constants/identity.py 100% <100%> (ø)
hvac/api/secrets_engines/identity.py 90.62% <90.62%> (ø)

@jeffwecan jeffwecan added this to the 0.6.6 milestone Oct 3, 2018

@jeffwecan jeffwecan removed the enhancement label Oct 3, 2018

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2018

@tiny-dancer: Fair warning, I'm planning on wrapping up the changes you have started here and will push those updates to your branch over the next couple days. 😀

@tiny-dancer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2018

Awesome! Thanks for picking up the slack 🙏

jeffwecan added some commits Oct 29, 2018

@jeffwecan jeffwecan modified the milestones: 0.7.1, 0.7.0 Oct 31, 2018

jeffwecan added some commits Oct 31, 2018

@jeffwecan jeffwecan force-pushed the tiny-dancer:feature/identity-secrets-engine branch from 4d3212c to 39bba98 Oct 31, 2018

jeffwecan added some commits Oct 31, 2018

Merge branch 'feature/identity-secrets-engine' of github.com:tiny-dan…
…cer/hvac into feature/identity-secrets-engine

@jeffwecan jeffwecan merged commit 1d82242 into hvac:master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Breakout Client Class Methods automation moved this from In progress to Done Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.