Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Auth Class #286

Merged
merged 5 commits into from Oct 2, 2018

Conversation

@jeffwecan
Copy link
Collaborator

commented Oct 2, 2018

Closes #283

jeffwecan added some commits Oct 2, 2018

@jeffwecan jeffwecan added this to the 0.6.5 milestone Oct 2, 2018

@jeffwecan jeffwecan added this to In progress in Breakout Client Class Methods via automation Oct 2, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2018

Codecov Report

Merging #286 into master will increase coverage by 0.58%.
The diff coverage is 98.48%.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   90.29%   90.87%   +0.58%     
==========================================
  Files          17       19       +2     
  Lines        1195     1260      +65     
==========================================
+ Hits         1079     1145      +66     
+ Misses        116      115       -1
Impacted Files Coverage Δ
hvac/api/constants.py 100% <100%> (ø)
hvac/api/azure.py 100% <100%> (+8.33%) ⬆️
hvac/api/auth/__init__.py 100% <100%> (ø) ⬆️
hvac/api/auth/azure.py 98.3% <98.3%> (ø)
hvac/v1/__init__.py 86.37% <0%> (+0.14%) ⬆️

@jeffwecan jeffwecan merged commit 39893f0 into hvac:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Breakout Client Class Methods automation moved this from In progress to Done Oct 2, 2018

@jeffwecan jeffwecan deleted the jeffwecan:jeffwecan/issue_283_azure_auth branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.