Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout secrets engines to their own category #311

Conversation

@jeffwecan
Copy link
Collaborator

commented Oct 29, 2018

Part 2 of 3 in our large refactor series of how we organize auth methods, secrets engines, and system backend classes. This moves all secrets engines-related classes under a new "secrets" property used to access instances of these classes under the Client class.

@jeffwecan jeffwecan added this to the 0.7.0 milestone Oct 29, 2018

@jeffwecan jeffwecan added this to In progress in Breakout Client Class Methods via automation Oct 29, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 29, 2018

Codecov Report

Merging #311 into master will decrease coverage by 0.05%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage    90.9%   90.85%   -0.06%     
==========================================
  Files          25       24       -1     
  Lines        1462     1443      -19     
==========================================
- Hits         1329     1311      -18     
+ Misses        133      132       -1
Impacted Files Coverage Δ
hvac/constants/client.py 100% <ø> (ø) ⬆️
hvac/api/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/v1/__init__.py 86.09% <66.66%> (-0.06%) ⬇️

@jeffwecan jeffwecan merged commit ae6f894 into hvac:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Breakout Client Class Methods automation moved this from In progress to Done Oct 29, 2018

@jeffwecan jeffwecan deleted the jeffwecan:rearrange_api_classes_a_smidge_secrets_edition branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.