Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert a few client deprecations #325

Merged
merged 2 commits into from Oct 31, 2018

Conversation

@jeffwecan
Copy link
Collaborator

commented Oct 31, 2018

Upon reflection, some of the refactoring in creating the new SystemBackend classes went a bit too far. This PR reverts a few of those changes ahead of the 0.7.0 release.

jeffwecan added some commits Oct 31, 2018

@jeffwecan jeffwecan added this to the 0.7.0 milestone Oct 31, 2018

@jeffwecan jeffwecan added this to In progress in Breakout Client Class Methods via automation Oct 31, 2018

@jeffwecan jeffwecan merged commit e3e0009 into hvac:master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Breakout Client Class Methods automation moved this from In progress to Done Oct 31, 2018

@jeffwecan jeffwecan deleted the jeffwecan:revert_a_few_client_deprecations branch Oct 31, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 31, 2018

Codecov Report

Merging #325 into master will decrease coverage by 0.65%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   90.97%   90.31%   -0.66%     
==========================================
  Files          37       37              
  Lines        1739     1735       -4     
==========================================
- Hits         1582     1567      -15     
- Misses        157      168      +11
Impacted Files Coverage Δ
hvac/api/system_backend/key.py 85.18% <ø> (-1.03%) ⬇️
hvac/api/system_backend/seal.py 100% <ø> (+3.33%) ⬆️
hvac/api/system_backend/policy.py 95% <ø> (+6.11%) ⬆️
hvac/api/system_backend/leader.py 100% <ø> (ø) ⬆️
hvac/constants/client.py 100% <ø> (ø) ⬆️
hvac/v1/__init__.py 85.67% <84%> (-0.3%) ⬇️
hvac/utils.py 75% <0%> (-15.63%) ⬇️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.