Skip to content

Add support for setting VAULT_ADDR and VAULT_TOKEN via env vars #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2019
Merged

Add support for setting VAULT_ADDR and VAULT_TOKEN via env vars #411

merged 2 commits into from
Mar 27, 2019

Conversation

mrsiesta
Copy link
Contributor

The PR adds the ability to set the VAULT_ADDR and VAULT_TOKEN from env vars.

@mrsiesta mrsiesta requested a review from jeffwecan March 27, 2019 19:55
jeffwecan
jeffwecan approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out, I'm down with adding this functionality since it mirrors the same sort of logic already baked into Vault's CLI utility.

Note to self: we need to call out the functional changes being introduced here in the release notes / change log.

@jeffwecan jeffwecan force-pushed the default_token_address branch from 635e240 to 9056d0e Compare March 27, 2019 21:39
@jeffwecan jeffwecan merged commit 591f6d1 into develop Mar 27, 2019
@jeffwecan jeffwecan deleted the default_token_address branch March 27, 2019 21:39
@jeffwecan jeffwecan added this to the 0.8.0 milestone Mar 29, 2019
@andytumelty andytumelty mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsiesta @jeffwecan