Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually do not install tests #418

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@eltoder
Copy link

commented Apr 1, 2019

In #294 tests directory was moved out from hvac with the intention to not
install tests into site-packages. However, find_packages() still finds and
installs it, this time as a top-level package. Pass it into exclude to really
skip it.

Same thing for docs.

Eugene Toder
Actually do not install tests
In #294 `tests` directory was moved out from `hvac` with the intention to not
install tests into site-packages. However, find_packages() still finds and
installs it, this time as a top-level package. Pass it into exclude to really
skip it.

Same thing for `docs`.
@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

🤦‍♂️ I totally whiffed on that one and it now makes a bunch of sense. I ended up having to update https://github.com/hvac/hvac/blob/develop/MANIFEST.in to keep the tests out of the hvac package after the change you're proposing didin't seem to be sufficient without realizing that both changes were (presumably) required.

@jeffwecan jeffwecan added the meta label Apr 1, 2019

@jeffwecan jeffwecan added this to the 0.8.2 milestone Apr 1, 2019

@jeffwecan
Copy link
Collaborator

left a comment

Thanks so much for the contribution @eltoder!

@jeffwecan jeffwecan merged commit de49e75 into hvac:develop Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eltoder

This comment has been minimized.

Copy link
Author

commented Apr 1, 2019

I think you could have used exclude=['hvac.tests*'] to exclude it from installation without moving it out, but having tests separately feels cleaner.

@jeffwecan jeffwecan modified the milestones: 0.8.3, 0.8.2 Apr 4, 2019

@jeffwecan jeffwecan referenced this pull request Apr 4, 2019

Merged

Release v0.8.2 #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.