Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radius auth #420

Merged
merged 3 commits into from Apr 5, 2019

Conversation

3 participants
@stevenmanton
Copy link
Contributor

commented Apr 1, 2019

This PR adds authentication via the RADIUS auth backend. Note that I haven't added mocked tests or tested the configuration functions. I have tested it against a working RADIUS backend for login, though.

Thoughts?

References #419

jeffwecan and others added some commits Mar 31, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #420 into develop will decrease coverage by 1.08%.
The diff coverage is 30.23%.

@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
- Coverage     91.2%   90.11%   -1.09%     
===========================================
  Files           45       46       +1     
  Lines         2364     2407      +43     
===========================================
+ Hits          2156     2169      +13     
- Misses         208      238      +30
Impacted Files Coverage Δ
hvac/api/auth_methods/__init__.py 76.19% <100%> (+1.19%) ⬆️
hvac/api/auth_methods/radius.py 28.57% <28.57%> (ø)

@jeffwecan jeffwecan self-requested a review Apr 4, 2019

@jeffwecan jeffwecan added this to the 0.8.3 milestone Apr 4, 2019

@jeffwecan
Copy link
Collaborator

left a comment

Thanks for the contribution @stevenmanton!

Ensure Classes for All Auth Methods and Secret Engines automation moved this from In progress to Reviewer approved Apr 5, 2019

@jeffwecan jeffwecan merged commit a928808 into hvac:develop Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Ensure Classes for All Auth Methods and Secret Engines automation moved this from Reviewer approved to Done Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.