Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.2 #424

Merged
merged 8 commits into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@jeffwecan
Copy link
Collaborator

commented Apr 4, 2019

BUG FIXES:

  • Fix priority of client url and VAULT_ADDR environment variable. GH-423
  • Update setup.py to only compile hvac package. GH-418

Thanks to @eltoder and @andytumelty for their lovely contributions.

Eugene Toder and others added some commits Apr 1, 2019

Eugene Toder
Actually do not install tests
In #294 `tests` directory was moved out from `hvac` with the intention to not
install tests into site-packages. However, find_packages() still finds and
installs it, this time as a top-level package. Pass it into exclude to really
skip it.

Same thing for `docs`.
Merge pull request #418 from eltoder/dont-install-tests
Actually do not install tests
Fix precedence of `VAULT_ADDR` environment variable vs client `url` p…
…arameter

Fixes #421.

The vault CLI priorities the `-address` flag over the `VAULT_ADDR`
environment variable. This commit aligns hvac to that behaviour.
Merge pull request #423 from andytumelty/develop
Fix priority of client url and VAULT_ADDR environment variable

@jeffwecan jeffwecan requested a review from mrsiesta Apr 4, 2019

@jeffwecan jeffwecan added this to the 0.8.2 milestone Apr 4, 2019

@jeffwecan jeffwecan requested a review from dbwpe Apr 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #424 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #424      +/-   ##
=========================================
+ Coverage    91.2%   91.2%   +<.01%     
=========================================
  Files          45      45              
  Lines        2364    2365       +1     
=========================================
+ Hits         2156    2157       +1     
  Misses        208     208
Impacted Files Coverage Δ
hvac/v1/__init__.py 86.13% <100%> (ø) ⬆️
hvac/constants/client.py 100% <100%> (ø) ⬆️

@jeffwecan jeffwecan merged commit c68da20 into master Apr 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeffwecan jeffwecan added the release label May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.