Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKI secret_engine implementation. #436

Merged
merged 9 commits into from May 25, 2019

Conversation

3 participants
@nledez
Copy link
Contributor

commented May 15, 2019

Do not merge now. I need to update python embedded doc.

But very interested by feed-backs :)

@jeffwecan jeffwecan added this to the 0.8.4 milestone May 15, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #436 into develop will decrease coverage by 0.35%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
- Coverage    87.88%   87.52%   -0.36%     
===========================================
  Files           48       50       +2     
  Lines         2468     2654     +186     
===========================================
+ Hits          2169     2323     +154     
- Misses         299      331      +32
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/pki.py 100% <100%> (ø)
hvac/adapters.py 94.2% <0%> (-0.25%) ⬇️
hvac/constants/gcp.py 100% <0%> (ø) ⬆️
hvac/api/secrets_engines/gcp.py 46.66% <0%> (ø)
@nledez

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@jeffwecan I think it's ready to merge.

@jeffwecan jeffwecan merged commit 129d1c0 into hvac:develop May 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Ensure Classes for All Auth Methods and Secret Engines automation moved this from In progress to Done May 25, 2019

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Thanks for the great contribution @nledez!

@nledez nledez deleted the nledez:vault_experiments branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.