Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Pass on GCP Secrets Engine Implementation #443

Merged
merged 6 commits into from May 23, 2019

Conversation

2 participants
@jeffwecan
Copy link
Collaborator

commented May 23, 2019

Implements #441

@jeffwecan jeffwecan added this to the 0.8.3 milestone May 23, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #443 into develop will decrease coverage by 0.95%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop     #443      +/-   ##
===========================================
- Coverage    87.88%   86.92%   -0.96%     
===========================================
  Files           48       49       +1     
  Lines         2468     2532      +64     
===========================================
+ Hits          2169     2201      +32     
- Misses         299      331      +32
Impacted Files Coverage Δ
hvac/constants/gcp.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/gcp.py 46.66% <46.66%> (ø)

@jeffwecan jeffwecan merged commit f551102 into hvac:develop May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Ensure Classes for All Auth Methods and Secret Engines automation moved this from In progress to Done May 23, 2019

@jeffwecan jeffwecan deleted the jeffwecan:secret_gcp branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.