Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-451 fix azure auth params #452

Merged
merged 4 commits into from May 28, 2019

Conversation

2 participants
@drewmullen
Copy link
Contributor

commented May 28, 2019

fixes for #451

include new param: num_uses

change param names:

  • bound_location -> bound_locations
  • bound_resource_group_names -> bound_resource_groups

jeffwecan and others added some commits May 25, 2019

Drew Mullen

@jeffwecan jeffwecan added the azure label May 28, 2019

@jeffwecan jeffwecan added this to the 0.9.2 milestone May 28, 2019

@jeffwecan jeffwecan self-requested a review May 28, 2019

@jeffwecan
Copy link
Collaborator

left a comment

Looks good! Will merge it in once tests pass.

@jeffwecan jeffwecan merged commit 9ad27d0 into hvac:develop May 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan added this to Closed in Bug / Feature Request Triage via automation May 28, 2019

@drewmullen

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@jeffwecan ik you just did a release this weekend. typically are they monthly cadence?

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

Aye, I have been shooting for a one release per month cadence over the past year or so. However, historically it has been 1-2ish months in reality. Releases normally get made when someone asks about an upcoming one enough (and/or when I have something I'd like release hah 👼). That said, I've been coming around to the idea that quicker incremental releases done as as anything worth shipping is merged is probably the happier path long term. Which is to say, if shipping this change today would help you out, I'd be down to try and make that happen. Otherwise I'll get to it by this time next week.

@drewmullen

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

youre a kind soul, @jeffwecan ! dont rush yourself for today. however, I would love it if you could shoot for sometime next week!

i gotta write some ansible modules against the database secret engine so im wondering if ill find more that needs to be fixed since its so new. next week gives me time to look at that new feature

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

Sounds good! I wouldn't mind lending a hand myself on filling in the documentation for that secrets engine if we don't get any other takers before then (re: #453).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.