Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Using Enterprise (Trial) Version of Vault For Travis CI Builds #478

Merged
merged 9 commits into from Jul 7, 2019

Conversation

Projects
None yet
3 participants
@jeffwecan
Copy link
Collaborator

commented Jun 17, 2019

Building off @drewmullen's #474 PR here to start using Vault enterprise during Travis CI builds. This will allow us to add test cases for enterprise only features (e.g., Namespaces, MFA, etc.). While this is technically mergeable as is, I may take a bit more time to see about adding some additional bits. In particular:

  • Update documentation to clarify how to run tests with or without the enterprise Vault version locally.
  • Add at least one test case for an enterprise only feature that is skipped when testing against Vault OSS to serve as an example / pattern on how to do such things. (Would be nice to keep local test runs available for folks that only care about Vault OSS.)
  • Ideally fix whatever bits in the Vault HA (with Consul as the backend) aren't working with the Enterprise version of things. While the related test cases are automatically skipped without HA available in the test environment, and there aren't all that many of them at that, it would be nice to get this sorted so we're not reducing coverage overall.
  • Either see if HashiCorp can publish a 0.11.6 version of the Enterprise binary or update the Travis CI build matrix to drop this version.
@codecov-io

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #478 into develop will increase coverage by 4.78%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #478      +/-   ##
===========================================
+ Coverage    83.28%   88.07%   +4.78%     
===========================================
  Files           52       52              
  Lines         2907     2691     -216     
===========================================
- Hits          2421     2370      -51     
+ Misses         486      321     -165
Impacted Files Coverage Δ
hvac/api/system_backend/namespace.py 100% <100%> (ø)
hvac/api/system_backend/__init__.py 96% <100%> (+0.16%) ⬆️
hvac/api/secrets_engines/aws.py 98.07% <0%> (-1.93%) ⬇️
hvac/api/auth_methods/__init__.py 76.19% <0%> (-1.09%) ⬇️
hvac/v1/__init__.py 86.24% <0%> (-0.26%) ⬇️
hvac/constants/aws.py 100% <0%> (ø) ⬆️
hvac/api/auth_methods/aws.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0f977...dcdc750. Read the comment docs.

@jeffwecan jeffwecan added the misc label Jul 7, 2019

@jeffwecan jeffwecan force-pushed the jeffwecan:enterprise_trial_ci branch 4 times, most recently from b6e1042 to 2dc8192 Jul 7, 2019

@jeffwecan jeffwecan changed the title Start Using Enterprise Version of Vault (Trial) For Travis CI Builds Start Using Enterprise (Trial) Version of Vault For Travis CI Builds Jul 7, 2019

@jeffwecan

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

I'm going to punt on figuring out what is up with the enterprise version and the HA / consul backed tests for now. We'll still at least get that coverage with the one OSS test case added explicitly for travis builds. I got about this far before giving up (failures were happening during Vault initialization):

2019-07-07T12:07:22.405-0500 [WARN]  storage.consul: appending trailing forward slash to path
2019-07-07T12:07:22.406-0500 [WARN]  no `api_addr` value specified in config or in VAULT_API_ADDR; falling back to detection if possible, but this value should be manually set
2019-07-07T12:07:22.893-0500 [INFO]  core: security barrier not initialized
2019-07-07T12:07:22.899-0500 [INFO]  core: security barrier not initialized
2019-07-07T12:07:22.902-0500 [INFO]  core: security barrier not initialized
2019-07-07T12:07:22.905-0500 [INFO]  core: security barrier initialized: shares=5 threshold=3
2019-07-07T12:07:22.925-0500 [INFO]  core: post-unseal setup starting
2019-07-07T12:07:22.928-0500 [INFO]  replication.wal: no log directories found: root=wal/logs/
2019-07-07T12:07:22.960-0500 [INFO]  replication.index.local: no index pages found
2019-07-07T12:07:22.961-0500 [INFO]  replication.index.local: no checkpoint found
2019-07-07T12:07:22.961-0500 [INFO]  replication.index: no previous commit, forcing re-index: path-type=2
2019-07-07T12:07:22.989-0500 [INFO]  replication.index.perf: no index pages found
2019-07-07T12:07:22.990-0500 [INFO]  replication.index.perf: no checkpoint found
2019-07-07T12:07:22.990-0500 [INFO]  replication.index: no previous commit, forcing re-index: path-type=1
2019-07-07T12:07:23.001-0500 [INFO]  core: loaded wrapping token key
2019-07-07T12:07:23.001-0500 [INFO]  core: successfully setup plugin catalog: plugin-directory=
2019-07-07T12:07:23.001-0500 [INFO]  core: no mounts; adding default mount table
2019-07-07T12:07:27.909-0500 [WARN]  storage.consul: check unable to talk with Consul backend: error="Put http://127.0.0.1:8500/v1/agent/check/fail/vault:127.0.0.1:8200:vault-sealed-check?note=Vault+Sealed: EOF"
2019-07-07T12:07:27.909-0500 [ERROR] replication.index.local: failed to persist page: size=0 page="{true 225 0 {} [] 0}" error="failed to persist: Put http://127.0.0.1:8500/v1/kv/vault/index-dr/pages/e1: EOF"
2019-07-07T12:07:27.909-0500 [ERROR] replication.index.periodic: failed to flush dirty pages: error="1 error occurred:
	* failed to persist page: failed to persist: Put http://127.0.0.1:8500/v1/kv/vault/index-dr/pages/e1: EOF

"
2019-07-07T12:07:27.909-0500 [ERROR] core: failed to persist mount table: error="Put http://127.0.0.1:8500/v1/txn: EOF"
2019-07-07T12:07:27.909-0500 [ERROR] core: failed to persist mount table: error="Put http://127.0.0.1:8500/v1/txn: EOF"
2019-07-07T12:07:27.909-0500 [INFO]  core: pre-seal teardown starting
2019-07-07T12:07:27.909-0500 [INFO]  core: stopping replication
2019-07-07T12:07:27.909-0500 [INFO]  core: closed sync connection
2019-07-07T12:07:27.909-0500 [INFO]  core: replication stopped
2019-07-07T12:07:27.909-0500 [ERROR] replication.index.local: failed to persist page: size=0 page="{true 225 0 {} [] 0}" error="failed to persist: Put http://127.0.0.1:8500/v1/kv/vault/index-dr/pages/e1: dial tcp 127.0.0.1:8500: connect: connection refused"
2019-07-07T12:07:27.909-0500 [ERROR] replication.index.periodic: failed to flush dirty pages: error="1 error occurred:
	* failed to persist page: failed to persist: Put http://127.0.0.1:8500/v1/kv/vault/index-dr/pages/e1: dial tcp 127.0.0.1:8500: connect: connection refused
@jeffwecan

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

Just going to split off some of these commits to different PRs (since that works better with the new release-drafter model of things here) and then rebase to drop them out of this PR before merging it...

@jeffwecan jeffwecan force-pushed the jeffwecan:enterprise_trial_ci branch from 18092b5 to dcdc750 Jul 7, 2019

@jeffwecan jeffwecan merged commit 509bc86 into hvac:develop Jul 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan deleted the jeffwecan:enterprise_trial_ci branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.