Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI Test Matrix With Latest Vault Version & Drop Python 3.6 #488

Merged
merged 2 commits into from Jul 7, 2019

Conversation

Projects
None yet
2 participants
@jeffwecan
Copy link
Collaborator

commented Jul 7, 2019

  • Tweaking supported Vault versions a smidge. Was inspired by #478
  • Dropping Python 3.6 test runs. We already have Python 3.7 coverage and dropping 3.6 will decrease the runtime of Travis CI builds quite a bit...
@jeffwecan

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

Treating this as a prerequisite for #478

@jeffwecan jeffwecan force-pushed the jeffwecan:update_test_matrix branch from 8bae398 to e901fbc Jul 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #488 into develop will increase coverage by 1.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    81.32%   83.24%   +1.92%     
===========================================
  Files           52       52              
  Lines         2907     2907              
===========================================
+ Hits          2364     2420      +56     
+ Misses         543      487      -56
Impacted Files Coverage Δ
hvac/api/secrets_engines/aws.py 98.07% <0%> (-1.93%) ⬇️
hvac/api/secrets_engines/transit.py 93.23% <0%> (+2.25%) ⬆️
hvac/api/secrets_engines/identity.py 93.65% <0%> (+20.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f2a2f...e901fbc. Read the comment docs.

@jeffwecan jeffwecan changed the title Update Test Matrix With Latest Vault Version, Drop Python 3.6 Runs Update Travis CI Test Matrix With Latest Vault Version & Drop Python 3.6 Jul 7, 2019

@jeffwecan jeffwecan merged commit b900c87 into hvac:develop Jul 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan deleted the jeffwecan:update_test_matrix branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.