Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Database generate_credentials Docstring Params #498

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@Tylerlhess
Copy link
Contributor

commented Jul 15, 2019

removed generate_credentials duplicate param name definition and replaced with param mount_point definition that was missed in last update.

Documentation fix
removed generate_credentials duplicate param name definition and replaced with param mount_point definition that was missed in last update.

@Tylerlhess Tylerlhess requested a review from hvac/hvac-maintainers as a code owner Jul 15, 2019

@update-docs

This comment has been minimized.

Copy link

commented Jul 15, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@codecov-io

This comment has been minimized.

Copy link

commented Jul 15, 2019

Codecov Report

Merging #498 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #498   +/-   ##
========================================
  Coverage    83.31%   83.31%           
========================================
  Files           53       53           
  Lines         2918     2918           
========================================
  Hits          2431     2431           
  Misses         487      487
Impacted Files Coverage Δ
hvac/api/secrets_engines/database.py 37.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e905b...508ba9e. Read the comment docs.

@drewmullen
Copy link
Contributor

left a comment

LGTM! thanks!

@drewmullen drewmullen merged commit 9748ed8 into hvac:develop Jul 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Tylerlhess Tylerlhess deleted the Tylerlhess:patch-1 branch Jul 15, 2019

@jeffwecan jeffwecan changed the title Documentation fix Fix Database generate_credentials Docstring Params Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.