Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consul configure_access/create_or_update_role Method Return Values #502

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@drewmullen
Copy link
Contributor

commented Jul 17, 2019

fixes: #496

@drewmullen drewmullen requested a review from hvac/hvac-maintainers as a code owner Jul 17, 2019

@update-docs

This comment has been minimized.

Copy link

commented Jul 17, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@jeffwecan
Copy link
Collaborator

left a comment

Thanks!

@jeffwecan jeffwecan added the bug label Jul 17, 2019

@drewmullen drewmullen merged commit b03739f into hvac:develop Jul 17, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@drewmullen drewmullen deleted the drewmullen:consul-engine-fix branch Jul 17, 2019

@vamshideveloper
Copy link
Contributor

left a comment

Looks good

@jeffwecan jeffwecan changed the title Fix consul secret engine return values Fix consul configure_access/create_or_update_role Method Return Values Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.