Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Active Directory Secrets Engine Support #508

Merged
merged 9 commits into from Jul 18, 2019

Conversation

@jeffwecan
Copy link
Collaborator

commented Jul 18, 2019

I was adding a couple tweaks on top of #507 and managed to accidentally wipe the relevant commits off @vamshideveloper's PR (sorry @vamshideveloper!). Re-opening the PR here with the original commits plus the tweaks I was attempting to add originally.

Content from the original PR description:

Module for Active directory
which will help us to manage AD through automation
I will also update hvac/hvac/api/secrets_engines/init.py to support ad.py

vamshideveloper and others added some commits Jul 18, 2019

@jeffwecan jeffwecan requested a review from hvac/hvac-maintainers as a code owner Jul 18, 2019

@update-docs

This comment has been minimized.

Copy link

commented Jul 18, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@jeffwecan jeffwecan merged commit e7c651c into hvac:develop Jul 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Ensure Classes for All Auth Methods and Secret Engines automation moved this from In progress to Done Jul 18, 2019

@jeffwecan jeffwecan deleted the jeffwecan:active_directory_tweaks branch Jul 18, 2019

@jeffwecan

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 18, 2019

Will get this released in a new hvac version over the next few days or so. Sorry again for messing up your branch @vamshideveloper!

@codecov-io

This comment has been minimized.

Copy link

commented Jul 18, 2019

Codecov Report

Merging #508 into develop will decrease coverage by 0.38%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #508      +/-   ##
===========================================
- Coverage    83.23%   82.84%   -0.39%     
===========================================
  Files           53       54       +1     
  Lines         2922     2949      +27     
===========================================
+ Hits          2432     2443      +11     
- Misses         490      506      +16
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/active_directory.py 38.46% <38.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96c031...98f6958. Read the comment docs.

@vamshideveloper

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

NP
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.