Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Recently Added Namespace Documentation In Toctree #509

Merged
merged 5 commits into from Jul 19, 2019

Conversation

@jeffwecan
Copy link
Collaborator

commented Jul 18, 2019

Funny story @drewmullen, we never actually patched in namespace.rst into a place that would get it pulled into the rendered docs / https://hvac.readthedocs.io!

checking consistency... 
/[...]/workspace/hvac/docs/usage/system_backend/namespace.rst: 
WARNING: document isn't included in any toctree

Tried to add a bit to the contributing docs to help folks avoid a similar deal in the future.

@jeffwecan jeffwecan requested a review from drewmullen Jul 18, 2019

@jeffwecan jeffwecan requested a review from hvac/hvac-maintainers as a code owner Jul 18, 2019

@jeffwecan jeffwecan force-pushed the jeffwecan:namespace_docs_inclusion branch from fb2af2e to 4ebea45 Jul 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 18, 2019

Codecov Report

Merging #509 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #509   +/-   ##
========================================
  Coverage    82.84%   82.84%           
========================================
  Files           54       54           
  Lines         2949     2949           
========================================
  Hits          2443     2443           
  Misses         506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c651c...4ebea45. Read the comment docs.

@drewmullen
Copy link
Contributor

left a comment

thanks for pointing this out and for adding to the CONTR. file!

@jeffwecan jeffwecan merged commit 101a33e into hvac:develop Jul 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeffwecan jeffwecan deleted the jeffwecan:namespace_docs_inclusion branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.