Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added userpass auth method #519

Merged
merged 5 commits into from Nov 20, 2019
Merged

Added userpass auth method #519

merged 5 commits into from Nov 20, 2019

Conversation

@vamshideveloper
Copy link
Contributor

vamshideveloper commented Aug 28, 2019

No description provided.

Added userpass auth method
Updated with userpass auth menthod
@vamshideveloper vamshideveloper requested a review from hvac/hvac-maintainers as a code owner Aug 28, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Aug 28, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #519 into develop will decrease coverage by 0.46%.
The diff coverage is 36.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #519      +/-   ##
===========================================
- Coverage    82.84%   82.37%   -0.47%     
===========================================
  Files           54       55       +1     
  Lines         2949     2979      +30     
===========================================
+ Hits          2443     2454      +11     
- Misses         506      525      +19
Impacted Files Coverage Δ
hvac/api/auth_methods/__init__.py 78.26% <100%> (+0.98%) ⬆️
hvac/api/auth_methods/userpass.py 34.48% <34.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ce194...e8bfe30. Read the comment docs.

Copy link
Collaborator

jeffwecan left a comment

Expanded docs would be good here! But I'll go ahead and merge this as-is when reviewing PRs to merge when cutting the next hvac release otherwise.

Apologies for the delay in getting to this PR!

@vamshideveloper

This comment has been minimized.

Copy link
Contributor Author

vamshideveloper commented Oct 11, 2019

Thank you

@jeffwecan jeffwecan merged commit 3d90e57 into hvac:develop Nov 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.