Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis HEAD build + Overhaul install scripts #535

Merged
merged 8 commits into from Oct 16, 2019

Conversation

@llamasoft
Copy link
Contributor

llamasoft commented Oct 16, 2019

The root cause of the Travis HEAD builds failing was that the git repo was cloned under the $GOPATH/src directory. This was causing go to get confused when looking for modules.

I also took the liberty of overhauling the installer scripts to add a few features:

  1. The Vault and Consul installer scripts now pass shellcheck with no warnings.
  2. The Vault installer can now download/compile Vault outside of Travis. This makes it easier for people like me to build from source.
  3. The Vault installer now has a "stable" version option that builds the latest git tag instead of the latest master commit. This should give considerably more useful test results instead of intermittent failures from bad commits to master.

I went ahead and updated the Travis builds to use the "stable" version instead of "head". The "head" builds do compile, but they result extra test failures because the integration tests can't parse the version number (they end with a "dev" suffix). It's something that will eventually need fixing, but it can probably wait for a later date.

All of that said, builds pass, but tests are failing on the "stable" builds. 馃槹

@llamasoft llamasoft requested a review from hvac/hvac-maintainers as a code owner Oct 16, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Oct 16, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #535 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #535   +/-   ##
========================================
  Coverage    82.95%   82.95%           
========================================
  Files           54       54           
  Lines         2968     2968           
========================================
  Hits          2462     2462           
  Misses         506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4b8a872...1d1924b. Read the comment docs.

Copy link
Collaborator

jeffwecan left a comment

Fantastic work! Thank ya sir!

@jeffwecan jeffwecan merged commit b3cfe8d into hvac:develop Oct 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@llamasoft llamasoft deleted the llamasoft:travis-fix branch Oct 16, 2019
@jeffwecan jeffwecan added the misc label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.