Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GET/LIST typos #536

Merged
merged 3 commits into from Oct 16, 2019
Merged

Fix GET/LIST typos #536

merged 3 commits into from Oct 16, 2019

Conversation

@llamasoft
Copy link
Contributor

llamasoft commented Oct 16, 2019

A few GET methods were incorrectly sending LIST requests.

@llamasoft llamasoft requested a review from hvac/hvac-maintainers as a code owner Oct 16, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Oct 16, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #536 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #536   +/-   ##
========================================
  Coverage    82.95%   82.95%           
========================================
  Files           54       54           
  Lines         2968     2968           
========================================
  Hits          2462     2462           
  Misses         506      506
Impacted Files Coverage Δ
hvac/api/secrets_engines/identity.py 93.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cfe8d...9460686. Read the comment docs.

Copy link
Collaborator

jeffwecan left a comment

:shipit:

@jeffwecan jeffwecan merged commit cdc1854 into hvac:develop Oct 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeffwecan jeffwecan added the misc label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.