Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rabbitmq secrets backend #540

Merged
merged 2 commits into from Nov 12, 2019
Merged

added rabbitmq secrets backend #540

merged 2 commits into from Nov 12, 2019

Conversation

@Dowwie
Copy link
Contributor

Dowwie commented Oct 29, 2019

No description provided.

@Dowwie Dowwie requested a review from hvac/hvac-maintainers as a code owner Oct 29, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Oct 29, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@Dowwie

This comment has been minimized.

Copy link
Contributor Author

Dowwie commented Nov 12, 2019

@jeffwecan I assume that everyone is busy and missed this PR. Is there any reason not to approve it? This expands secrets backend coverage to include RabbitMQ. Thx.

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

jeffwecan commented Nov 12, 2019

Indeed! Sorry for missing it until now. If you can address the linting error documented in the PR Travis CI build, we can work on getting it merged:

flake8 run-test: commands[0] | flake8
./hvac/api/secrets_engines/rabbitmq.py:139:1: W391 blank line at end of file

https://travis-ci.org/hvac/hvac/jobs/604520514?utm_medium=notification&utm_source=github_status

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #540 into develop will decrease coverage by 0.34%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #540      +/-   ##
==========================================
- Coverage    82.95%   82.6%   -0.35%     
==========================================
  Files           54      55       +1     
  Lines         2968    2995      +27     
==========================================
+ Hits          2462    2474      +12     
- Misses         506     521      +15
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/rabbitmq.py 42.3% <42.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc1854...7f9757e. Read the comment docs.

@Dowwie

This comment has been minimized.

Copy link
Contributor Author

Dowwie commented Nov 12, 2019

@jeffwecan done.

@jeffwecan jeffwecan merged commit 41894c1 into hvac:develop Nov 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.