Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad gateway from Vault #542

Merged
merged 1 commit into from Nov 20, 2019
Merged

Handle bad gateway from Vault #542

merged 1 commit into from Nov 20, 2019

Conversation

@DaveDeCaprio
Copy link
Contributor

DaveDeCaprio commented Nov 19, 2019

We were getting vault 502's that were not coming through in the client properly.

This pull requests add explicit support for 502 Bad Gateway errors from vault.

This also handles the case where vault returns a set of JSON errors but a status code that is unrecognized by the client. Previously this would cause message to be None and UnexpectedException(None) would be returned.

@DaveDeCaprio DaveDeCaprio requested a review from hvac/hvac-maintainers as a code owner Nov 19, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Nov 19, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #542 into develop will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
- Coverage     82.6%   82.59%   -0.02%     
===========================================
  Files           55       55              
  Lines         2995     2999       +4     
===========================================
+ Hits          2474     2477       +3     
- Misses         521      522       +1
Impacted Files Coverage Δ
hvac/exceptions.py 100% <100%> (ø) ⬆️
hvac/utils.py 77.14% <66.66%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41894c1...151ac32. Read the comment docs.

Copy link
Contributor

drewmullen left a comment

looks good. thanks for your contribution
https://http.cat/502

@drewmullen drewmullen merged commit 9bed302 into hvac:develop Nov 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeffwecan jeffwecan added the misc label Nov 20, 2019
jeffwecan added a commit that referenced this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.