Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a correct endpoint for CRL retrieving #547

Merged
merged 3 commits into from Dec 4, 2019

Conversation

@findmyname666
Copy link

findmyname666 commented Dec 4, 2019

Use a correct Vault endpoint to fetch CRL in PEM format - see DOC.

@findmyname666 findmyname666 requested a review from hvac/hvac-maintainers as a code owner Dec 4, 2019
@update-docs

This comment has been minimized.

Copy link

update-docs bot commented Dec 4, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
See: https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#documentation

…o string due to pyton2.7
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #547 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #547   +/-   ##
========================================
  Coverage    82.13%   82.13%           
========================================
  Files           56       56           
  Lines         3029     3029           
========================================
  Hits          2488     2488           
  Misses         541      541
Impacted Files Coverage Δ
hvac/api/secrets_engines/pki.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f021cc0...d5bd04e. Read the comment docs.

Copy link
Collaborator

jeffwecan left a comment

Ah yeah good catch! Looks like we ended up duplicating the sort of request read_crl_configuration() handles here..

@jeffwecan jeffwecan merged commit ae0fdc6 into hvac:develop Dec 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@findmyname666 findmyname666 deleted the findmyname666:read_crl_endpoint branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.