Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes close quotes in example usage of read_secret_version #557

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@philherbert
Copy link
Contributor

philherbert commented Feb 11, 2020

for those of us who are reckless copy-pasters

for those of us who are reckless copy-pasters
@philherbert philherbert requested a review from hvac/hvac-maintainers as a code owner Feb 11, 2020
Copy link
Collaborator

jeffwecan left a comment

Awesome, thank you!

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

jeffwecan commented Feb 11, 2020

Ideally we'll move these examples over to doctest in the future to avoid such typo's in the future. :)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #557 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #557   +/-   ##
========================================
  Coverage    82.13%   82.13%           
========================================
  Files           56       56           
  Lines         3029     3029           
========================================
  Hits          2488     2488           
  Misses         541      541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1027d...ce5c4e4. Read the comment docs.

@jeffwecan jeffwecan merged commit 760d5b0 into hvac:develop Feb 11, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.