approle - fix metadata for generated secret IDs, re-add wrap_ttl
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
bug
auth methods
briantist
force-pushed
the
send-metadata-only-if-not-empty
branch
from
87605cc to
b26c102
Compare
Codecov Report
@@ Coverage Diff @@
## develop #782 +/- ##
===========================================
- Coverage 81.64% 81.57% -0.08%
===========================================
Files 65 65
Lines 3002 3006 +4
===========================================
+ Hits 2451 2452 +1
- Misses 551 554 +3
|
Update: I'm a maintainer now (funny how that happens) 😅 I've made some updates to the PR:
Thank you for the original issue and the PR @Prividen ! Sorry it took so long to get addressed. |
briantist
previously approved these changes
Feb 19, 2023
briantist
changed the title
wrap_ttl
briantist
approved these changes
Feb 19, 2023
dhuckins
reviewed
Feb 22, 2023
dhuckins
approved these changes
Feb 28, 2023
briantist
added a commit
that referenced
this pull request
Mar 6, 2023
) * approle.generate_secret_id(): send metadata only if it not empty * update integration tests (also for custom secret_id) * update unit tests (also for custom secret_id) * fix custom_secret_id metadata processing * blackify * add back support for wrap_ttl --------- Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
briantist
added a commit
to briantist/hvac
that referenced
this pull request
May 10, 2023
…vac#782) * approle.generate_secret_id(): send metadata only if it not empty * update integration tests (also for custom secret_id) * update unit tests (also for custom secret_id) * fix custom_secret_id metadata processing * blackify * add back support for wrap_ttl --------- Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781
Fixes #950
Fixes #683
Closes #778