-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add arguments to create_or_update_role() from old API #842
Conversation
Codecov Report
@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 84.78% 82.08% -2.71%
==========================================
Files 65 65
Lines 3083 3019 -64
==========================================
- Hits 2614 2478 -136
- Misses 469 541 +72
|
085b858
to
9dbfa98
Compare
fa3da73
to
a216803
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @intgr , thanks for submitting this! Would you be able to take a look at the tests for token auth as well, and add some coverage for these parameters?
The previous, deprecated `create_token_role()` method has arguments `period` and `explicit_max_ttl` that were dropped in the new one for some reason.
a216803
to
715f6b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@intgr thanks again for this PR, I've gone ahead an switched the parameter order and added some unit tests for token auth after rebasing your branch. Cheers!
The previous, deprecated
create_token_role()
method has argumentsperiod
andexplicit_max_ttl
that were dropped in the new one for some reason (in #734).Re-added these two arguments to the new
create_or_update_role()
method (using new spellingtoken_period
,token_explicit_max_ttl
).There are plenty more that are supported by Vault but missing here: https://www.vaultproject.io/api-docs/auth/token#create-update-token-role