Skip to content

Add new field auto_rotate_period on transit key management #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2023
Merged

Add new field auto_rotate_period on transit key management #903

merged 3 commits into from
Feb 19, 2023

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Oct 18, 2022 •
edited by briantist
Loading

Implement new auto_rorate_period on transit create_key and update_key

Resolves #902

@sebglon sebglon requested a review from a team as a code owner October 18, 2022 12:38
@colin-pm colin-pm added transit Transit secrets engine enhancement a new feature or addition labels Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #903 (13eebb8) into develop (026d6b5) will increase coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
+ Coverage    81.34%   81.64%   +0.30%     
===========================================
  Files           65       65              
  Lines         2969     3002      +33     
===========================================
+ Hits          2415     2451      +36     
+ Misses         554      551       -3
Impacted Files Coverage Δ
hvac/api/secrets_engines/transit.py 90.78% <ø> (ø)
hvac/api/auth_methods/mfa.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/kv.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/identity.py 94.00% <0.00%> (+0.02%) ⬆️
hvac/utils.py 77.27% <0.00%> (+0.20%) ⬆️
hvac/adapters.py 86.73% <0.00%> (+0.27%) ⬆️
hvac/api/vault_api_category.py 95.12% <0.00%> (+0.67%) ⬆️
hvac/v1/__init__.py 87.26% <0.00%> (+3.43%) ⬆️
hvac/api/system_backend/__init__.py 100.00% <0.00%> (+3.84%) ⬆️

@colin-pm
Copy link
Member

colin-pm commented Nov 5, 2022

Change overall LGTM, thanks for the contribution!

Can you run black and amend your commit?

@adammike @briantist This field appears to be added in v1.10.x. Thankfully it looks like using the parameter doesn't break the integration tests for <1.10.x, however should it be on us to mark when these fields were added?

@briantist
Copy link
Contributor

This field appears to be added in v1.10.x. Thankfully it looks like using the parameter doesn't break the integration tests for <1.10.x, however should it be on us to mark when these fields were added?

Yes, we don't have to be perfect about it but when possible we should mark when a specific documented field was added to Vault, especially if it does not pre-date the versions of Vault we officially support (but we should still seek to do it even if it does).

@sebglon
Copy link
Contributor Author

sebglon commented Jan 19, 2023

@colin-pm Format is fixed
Do you need more change on my side?

@sebglon sebglon force-pushed the develop branch 2 times, most recently from 610b18b to b10df5b Compare January 19, 2023 13:13
@briantist briantist self-assigned this Jan 28, 2023
@briantist briantist added this to the 1.1.0 milestone Feb 19, 2023
briantist
briantist previously approved these changes Feb 19, 2023
View reviewed changes
@briantist briantist dismissed their stale review February 19, 2023 01:44

quick change

briantist
briantist reviewed Feb 19, 2023
View reviewed changes
@briantist briantist merged commit d7e9557 into hvac:develop Feb 19, 2023
@briantist
Copy link
Contributor

@sebglon thanks very much for this contribution!

briantist added a commit that referenced this pull request Mar 6, 2023
@sebglon @briantist
Add new field auto_rotate_period on transit key management (#903)
96a36ed 
* Add new field `auto_rotate-period` on transit key management

* Add new field auto_rotate-period on transit key management

Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>

* Apply suggestions from code review

---------

Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>
Co-authored-by: Sébastien GLON <sebastien.glon@ubble.ai>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
briantist added a commit to briantist/hvac that referenced this pull request May 10, 2023
@sebglon @briantist
Add new field auto_rotate_period on transit key management (hvac#903)
a4ecd2e 
* Add new field `auto_rotate-period` on transit key management

* Add new field auto_rotate-period on transit key management

Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>

* Apply suggestions from code review

---------

Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>
Co-authored-by: Sébastien GLON <sebastien.glon@ubble.ai>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
enhancement a new feature or addition transit Transit secrets engine
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Implement the new field auto_rotate_period on transit function
3 participants
@sebglon @colin-pm @briantist