-
Notifications
You must be signed in to change notification settings - Fork 393
Remove deprecated python syntax #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
There's a problem with the way we do caching of the virtual environment in our workflows. I'm going to put up a PR for that and then I'd like this to be re-based so we can run the tests again. |
Codecov Report
@@ Coverage Diff @@
## develop #909 +/- ##
===========================================
- Coverage 82.93% 80.87% -2.06%
===========================================
Files 59 59
Lines 2748 2761 +13
===========================================
- Hits 2279 2233 -46
- Misses 469 528 +59
|
should be all set! (not sure what's happening with codecov here... 🤷 ) |
Small nitpick, do you mind rebasing your two commits on top of develop? I'd like to avoid having any merge commits included in our development branch. Otherwise change lgtm, thanks for the PR! |
I've disabled the merge commit method for this repository (hope that's ok) so that the default is now "Squash and merge" which will eliminate any merge commits in
I've been trying to figure out the coverage issues too. All I can tell so far is that the inexplicable coverage drops all seem to be in files related to enterprise features. I don't see why that would be happening though since the enterprise tests were turned off a while ago so those coverage drops should already be the baseline. Maybe when we re-enable those tests this issue will go away, but I can't be sure yet. |
* replaced old metaclass style with new style Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> * abstractproperty Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
* replaced old metaclass style with new style Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> * abstractproperty Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
* replaced old metaclass style with new style Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> * abstractproperty Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com> Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
this PR removes older/deprecated python syntax from the code base
specifically:
abc.abstractproperty
decorator https://docs.python.org/3/library/abc.html#abc.abstractproperty