Skip to content

Remove deprecated python syntax #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Nov 2, 2022

this PR removes older/deprecated python syntax from the code base
specifically:

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins dhuckins requested a review from a team as a code owner November 2, 2022 15:00
@briantist
Copy link
Contributor

briantist commented Nov 13, 2022

There's a problem with the way we do caching of the virtual environment in our workflows. I'm going to put up a PR for that and then I'd like this to be re-based so we can run the tests again.

@briantist
Copy link
Contributor

@dhuckins with #913 merged, would you mind rebasing from develop and pushing again?

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #909 (8ba913f) into develop (5c91597) will decrease coverage by 2.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #909      +/-   ##
===========================================
- Coverage    82.93%   80.87%   -2.06%     
===========================================
  Files           59       59              
  Lines         2748     2761      +13     
===========================================
- Hits          2279     2233      -46     
- Misses         469      528      +59     
Impacted Files Coverage Δ
hvac/adapters.py 86.73% <100.00%> (+0.13%) ⬆️
hvac/api/system_backend/system_backend_mixin.py 100.00% <100.00%> (ø)
hvac/api/vault_api_base.py 100.00% <100.00%> (ø)
hvac/api/vault_api_category.py 95.12% <100.00%> (+0.67%) ⬆️
hvac/api/secrets_engines/transform.py 29.68% <0.00%> (-42.97%) ⬇️
hvac/api/system_backend/namespace.py 50.00% <0.00%> (-33.34%) ⬇️
hvac/api/auth_methods/mfa.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/kv.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/identity.py 94.00% <0.00%> (+0.02%) ⬆️
hvac/utils.py 77.27% <0.00%> (+0.20%) ⬆️
... and 2 more

@dhuckins
Copy link
Contributor Author

should be all set! (not sure what's happening with codecov here... 🤷 )

@colin-pm
Copy link
Member

Small nitpick, do you mind rebasing your two commits on top of develop? I'd like to avoid having any merge commits included in our development branch. Otherwise change lgtm, thanks for the PR!

@briantist
Copy link
Contributor

Small nitpick, do you mind rebasing your two commits on top of develop? I'd like to avoid having any merge commits included in our development branch. Otherwise change lgtm, thanks for the PR!

I've disabled the merge commit method for this repository (hope that's ok) so that the default is now "Squash and merge" which will eliminate any merge commits in develop.

should be all set! (not sure what's happening with codecov here... 🤷 )

I've been trying to figure out the coverage issues too. All I can tell so far is that the inexplicable coverage drops all seem to be in files related to enterprise features. I don't see why that would be happening though since the enterprise tests were turned off a while ago so those coverage drops should already be the baseline. Maybe when we re-enable those tests this issue will go away, but I can't be sure yet.

@colin-pm colin-pm merged commit 3e70e67 into hvac:develop Dec 15, 2022
sebglon pushed a commit to sebglon/hvac that referenced this pull request Jan 19, 2023
* replaced old metaclass style with new style

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* abstractproperty

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@briantist briantist added the maintenance General technical debt label Mar 4, 2023
@briantist briantist added this to the 1.1.0 milestone Mar 4, 2023
@briantist briantist added the misc Used as a release-drafter "category" label Mar 4, 2023
briantist pushed a commit that referenced this pull request Mar 6, 2023
* replaced old metaclass style with new style

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* abstractproperty

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
briantist pushed a commit to briantist/hvac that referenced this pull request May 10, 2023
* replaced old metaclass style with new style

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* abstractproperty

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General technical debt misc Used as a release-drafter "category"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants