-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't cache on py3.6 windows combo #916
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
+ Coverage 80.84% 80.95% +0.11%
===========================================
Files 59 59
Lines 2756 2772 +16
===========================================
+ Hits 2228 2244 +16
Misses 528 528
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would avoid merging this unless we are sure all the commits are squashed together.
@colin-pm I disabled merge commits for PRs in this repo; the default is now "Squash and merge" and the only way to have a PR result in multiple commits in the base branch is to click the drop-down and choose "Rebase and merge" which I expect we'll never use. That should avoid us having to manually squash or accidentally merging intermediate commits :) |
* don't cache on py3.6 windows combo * singles * opposite * hmmm * another shot * again
* don't cache on py3.6 windows combo * singles * opposite * hmmm * another shot * again
* don't cache on py3.6 windows combo * singles * opposite * hmmm * another shot * again
Follow up to
For some reason this cache restores corrupted somehow and we keep having to delete it to get successful runs. Python 3.6 is getting removed soon, for now we'll just skip the cache on this one combo.