Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't cache on py3.6 windows combo #916

Merged
merged 6 commits into from
Nov 20, 2022

Conversation

briantist
Copy link
Contributor

@briantist briantist commented Nov 20, 2022

Follow up to

For some reason this cache restores corrupted somehow and we keep having to delete it to get successful runs. Python 3.6 is getting removed soon, for now we'll just skip the cache on this one combo.

@briantist briantist added bug CI/CD related to CI/CD (not necessarily tests) labels Nov 20, 2022
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #916 (2855aaa) into develop (dbe0c01) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #916      +/-   ##
===========================================
+ Coverage    80.84%   80.95%   +0.11%     
===========================================
  Files           59       59              
  Lines         2756     2772      +16     
===========================================
+ Hits          2228     2244      +16     
  Misses         528      528              
Impacted Files Coverage Δ
hvac/api/auth_methods/mfa.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/kv.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/identity.py 94.00% <0.00%> (+0.02%) ⬆️
hvac/utils.py 77.27% <0.00%> (+0.20%) ⬆️
hvac/adapters.py 86.86% <0.00%> (+0.27%) ⬆️
hvac/api/vault_api_category.py 95.12% <0.00%> (+0.67%) ⬆️

@briantist briantist marked this pull request as ready for review November 20, 2022 14:43
@briantist briantist requested a review from a team as a code owner November 20, 2022 14:43
Copy link
Member

@colin-pm colin-pm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would avoid merging this unless we are sure all the commits are squashed together.

@briantist
Copy link
Contributor Author

LGTM, but I would avoid merging this unless we are sure all the commits are squashed together.

@colin-pm I disabled merge commits for PRs in this repo; the default is now "Squash and merge" and the only way to have a PR result in multiple commits in the base branch is to click the drop-down and choose "Rebase and merge" which I expect we'll never use.

That should avoid us having to manually squash or accidentally merging intermediate commits :)

@briantist briantist merged commit 500511a into hvac:develop Nov 20, 2022
@briantist briantist deleted the gha/cache-workaround branch November 20, 2022 15:38
sebglon pushed a commit to sebglon/hvac that referenced this pull request Jan 19, 2023
* don't cache on py3.6 windows combo

* singles

* opposite

* hmmm

* another shot

* again
briantist added a commit that referenced this pull request Mar 6, 2023
* don't cache on py3.6 windows combo

* singles

* opposite

* hmmm

* another shot

* again
briantist added a commit to briantist/hvac that referenced this pull request May 10, 2023
* don't cache on py3.6 windows combo

* singles

* opposite

* hmmm

* another shot

* again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/CD related to CI/CD (not necessarily tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants