-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS secret engine - fix generate_credentials
for STS endpoint
#934
Merged
briantist
merged 1 commit into
hvac:develop
from
briantist:secrets/aws/generate_credentials-param-passing
Feb 23, 2023
Merged
AWS secret engine - fix generate_credentials
for STS endpoint
#934
briantist
merged 1 commit into
hvac:develop
from
briantist:secrets/aws/generate_credentials-param-passing
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
bug
enhancement
a new feature or addition
aws
AWS auth method and/or secrets engine
secrets engines
generally related to a Vault secrets engine
minor
Used as part of release-drafter's version-resolver configuration
labels
Jan 8, 2023
sunchill06
previously approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for taking care of this.
briantist
force-pushed
the
secrets/aws/generate_credentials-param-passing
branch
from
January 27, 2023 23:39
187a10b
to
d70938d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #934 +/- ##
===========================================
+ Coverage 81.34% 81.55% +0.21%
===========================================
Files 65 65
Lines 2969 3003 +34
===========================================
+ Hits 2415 2449 +34
Misses 554 554
|
dhuckins
approved these changes
Feb 22, 2023
thanks for reviewing @dhuckins ! |
briantist
added a commit
that referenced
this pull request
Mar 6, 2023
briantist
added a commit
to briantist/hvac
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aws
AWS auth method and/or secrets engine
bug
enhancement
a new feature or addition
minor
Used as part of release-drafter's version-resolver configuration
secrets engines
generally related to a Vault secrets engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
Closes #932
The
generate_credentials
endpoint was not properly passing parameters when calling thests
endpoint, so all parameters were being ignored.The method was also using the
PUT
verb, even though the docs specifyPOST
. According to the Vault documentation this was ok because for the time being, the Vault API consideredPUT
andPOST
to be equivalent, however I've updated the method to usePOST
anyway.Changes to
generate_credentials
:_adapter.post()
instead of_adapter.put()
name
from the parameters passed to the endpointjson
parameter)role_session_name
parameter to the methodThe addition of
role_session_name
means we'll release this in the next minor version after it gets merged.