-
Notifications
You must be signed in to change notification settings - Fork 393
feat: add support for disable_local_ca_jwt
in the Kubernetes auth method
#997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@briantist I finally decided to start over this PR, hope that's fine for you :) |
Codecov Report
@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 81.98% 81.87% -0.11%
==========================================
Files 65 65
Lines 3019 2985 -34
==========================================
- Hits 2475 2444 -31
+ Misses 544 541 -3
|
Hi @fad3t , I'm sorry to report another major branch/workflow update in the The Since your PR was opened before this change, I have:
At least this time there's no painful interactive rebasing ;) I believe the changes I made are all that needs to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for submitting this and adding tests!
Thank you @briantist ! |
@briantist any idea when 1.2.0 will be released? |
@fad3t it's close, I hope to get back to wrapping up |
Follow-up of #972
Hi,
First of all thanks for developing this great project :)
I would like to propose my first contribution, about adding the support for the disable_local_ca_jwt in the Kubernetes auth method (cf. https://developer.hashicorp.com/vault/api-docs/auth/kubernetes#disable_local_ca_jwt).
This has been tested and it looks good; please let me know if anything else is needed/missing.
Thanks!
Fred