Skip to content

feat: add support for disable_local_ca_jwt in the Kubernetes auth method #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

fad3t
Copy link
Contributor

@fad3t fad3t commented Jun 15, 2023

Follow-up of #972


Hi,

First of all thanks for developing this great project :)
I would like to propose my first contribution, about adding the support for the disable_local_ca_jwt in the Kubernetes auth method (cf. https://developer.hashicorp.com/vault/api-docs/auth/kubernetes#disable_local_ca_jwt).

This has been tested and it looks good; please let me know if anything else is needed/missing.

Thanks!
Fred

@fad3t fad3t requested a review from a team as a code owner June 15, 2023 06:55
@fad3t
Copy link
Contributor Author

fad3t commented Jun 15, 2023

@briantist I finally decided to start over this PR, hope that's fine for you :)

@briantist briantist self-assigned this Jun 15, 2023
@briantist briantist added auth methods generally related to a Vault auth method kubernetes Kubernetes auth method labels Jun 15, 2023
@briantist briantist added this to the 1.2.0 milestone Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #997 (67d4d59) into main (31aca14) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 67d4d59 differs from pull request most recent head 82419e8. Consider uploading reports for the commit 82419e8 to get more accurate results

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   81.98%   81.87%   -0.11%     
==========================================
  Files          65       65              
  Lines        3019     2985      -34     
==========================================
- Hits         2475     2444      -31     
+ Misses        544      541       -3     
Impacted Files Coverage Δ
hvac/api/auth_methods/kubernetes.py 89.36% <ø> (ø)
hvac/api/auth_methods/token.py 83.33% <100.00%> (ø)

... and 7 files with indirect coverage changes

@briantist briantist changed the base branch from develop to main June 17, 2023 20:27
@briantist
Copy link
Contributor

Hi @fad3t , I'm sorry to report another major branch/workflow update in the hvac project, just as you've re-submitted this PR, but I think this will be the last!

The hvac project is simplifying its developer workflow and removing the develop branch. Please be aware for future PRs that the project's default branch is now main.

Since your PR was opened before this change, I have:

  • updated your PR to merge into the project's main branch
  • rebased your branch against main and force-pushed it (please pull before making any further changes)

At least this time there's no painful interactive rebasing ;) I believe the changes I made are all that needs to be done.

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for submitting this and adding tests!

@briantist briantist merged commit 54ab41b into hvac:main Jun 18, 2023
@briantist briantist added enhancement a new feature or addition minor Used as part of release-drafter's version-resolver configuration labels Jun 18, 2023
@fad3t
Copy link
Contributor Author

fad3t commented Jun 18, 2023

Thank you @briantist !

@fad3t
Copy link
Contributor Author

fad3t commented Aug 9, 2023

@briantist any idea when 1.2.0 will be released?

@briantist
Copy link
Contributor

@fad3t it's close, I hope to get back to wrapping up v1.2.0 soon. I was away for several weeks, so now I have a lot of catching up to do, but it was already close when I left. I am also waiting for reviews from other maintainers on a few things. So I think it will be before the end of this month, but always hard to predict since it is all volunteer time. Thanks for your patience and thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth methods generally related to a Vault auth method enhancement a new feature or addition kubernetes Kubernetes auth method minor Used as part of release-drafter's version-resolver configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants