Dashboard components #1

Merged
merged 11 commits into from Apr 19, 2012

3 participants

@chrisroberts
Heavy Water Operations Cookbooks member

Adds LWRP for adding components to dashboards.

@fujin

is this a typo? forecasts?

@fujin

this should be changed -- forecasts as well

@fujin

I really don't like the idea of this.. can we package unicorn and install it instead of manipulating the bundler file? Is there a way for bundler to read in additional gemfiles during bundle install, supplemented? like a bundler.d ?

Chef also has a built in FileEdit for doing stuff like this -- the Upstart provider uses it to adjust 'start on' / 'stop on' lines.

Heavy Water Operations Cookbooks member

No, bundler is very annoying in this regard (as opposed to something like pythons virtenvs) that you have to have the gems you want specified within the Gemfile. It is possible to get things working by doing some setup magic in the unicorn config file + ensuring that the gems on the system match what are specified in the Gemfile.lock. This ends up being more brittle than just modifying the Gemfile to include what we need. I'll take a gander for the file edit bits available. I would much rather do that than shell out.

@fujin

Looks really good, see my comments on individual commits

@webframp
Heavy Water Operations Cookbooks member

This is a lot of work for this pull request. It looks complete at this point so I'm going to merge this set of changes

@webframp webframp merged commit 0331f2e into hw-cookbooks:master Apr 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment