fix(ui): unified timeformats with yyyy/mm #450
Conversation
WalkthroughThe changes in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
bugs
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
web-frontend/src/pages/About.vue (1)
Line range hint
1-196: Consider comprehensive date format unificationWhile the career history section has been updated to use yyyy/mm format, this PR could be more comprehensive by including similar updates to education and publication dates. This would fully achieve the goal of unified time formats across the site as mentioned in issue #449.
Additionally, consider adding end-to-end tests to verify date format consistency once merged into the main branch, as mentioned in the PR description.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
web-frontend/src/pages/About.vue(1 hunks)
🔇 Additional comments (2)
web-frontend/src/pages/About.vue (2)
Line range hint 171-175: Verify education dates format consistency
While career history dates have been updated to yyyy/mm format, the education section might need similar treatment. The current implementation directly renders dates from the API response without formatting.
Consider using a date formatting function to ensure consistency:
- <div> {{ e.start }} - {{ e.end }} : {{ e.title }} </div>
+ <div> {{ formatDate(e.start) }} - {{ formatDate(e.end) }} : {{ e.title }} </div>Add this to your script setup:
const formatDate = (date) => {
if (!date) return '';
const d = new Date(date);
return `${d.getFullYear()}/${String(d.getMonth() + 1).padStart(2, '0')}`;
};Line range hint 184-187: Standardize publication dates format
For consistency with the new yyyy/mm format, publication dates should also be standardized.
Update the template to use the same date formatting function suggested for education dates:
- <li> Presented at {{ pb.date }}, <a :href="pb.link" target="_target">Download Link(pdf)</a></li>
+ <li> Presented at {{ formatDate(pb.date) }}, <a :href="pb.link" target="_target">Download Link(pdf)</a></li>| <li>2024/10 - Present: Resident Solutions Engineer at <a href="https://www.hashicorp.com/" target="_blank" rel="noopener noreferrer">HashiCorp</a></li> | ||
| <li>2021/01 - 2023/12: Chief Technology Officer at <a href="https://glocalist.co/ja-JP/" target="_blank" rel="noopener noreferrer">Glocalist</a></li> | ||
| <li>2019/06 - 2024/10: Telco Solutions Architect at <a href="https://www.vmware.com" target="_blank" rel="noopener noreferrer">VMware</a><br>(merged by Broadcom)</li> |
There was a problem hiding this comment.
Fix date inconsistency in career history
There appears to be an overlap in the timeline:
- HashiCorp position starts from 2024/10
- VMware position ends in 2024/10
This creates ambiguity about which role is current. Please clarify the exact dates to avoid confusion.
Issue/PR link
closes: #449
What does this PR do?
Describe what changes you make in your branch:
yyyy/mmin About.vue(Optional) Additional Contexts
Describe additional information for reviewers (i.e. What does not included)
mainto confirm changes would be appliedSummary by CodeRabbit