From 6ec0178b3355935e341789bc88780867a7b7afa4 Mon Sep 17 00:00:00 2001 From: hwakabh Date: Sun, 1 Dec 2024 23:25:28 +0900 Subject: [PATCH 1/3] refactor(ui): replaced static svc with tabler-icon components. --- web-frontend/package-lock.json | 25 +++++++++++++++++++ web-frontend/package.json | 1 + web-frontend/src/components/icons/Contact.vue | 20 ++++++--------- .../src/components/icons/Facebook.vue | 19 ++++++-------- web-frontend/src/components/icons/GitHub.vue | 19 ++++++-------- .../src/components/icons/Instagram.vue | 21 ++++++---------- .../src/components/icons/LinkedIn.vue | 23 ++++++----------- web-frontend/src/components/icons/X.vue | 20 ++++++--------- 8 files changed, 68 insertions(+), 80 deletions(-) diff --git a/web-frontend/package-lock.json b/web-frontend/package-lock.json index 3fc37a5a..2f2c3f16 100644 --- a/web-frontend/package-lock.json +++ b/web-frontend/package-lock.json @@ -8,6 +8,7 @@ "name": "web-frontend", "version": "0.0.0", "dependencies": { + "@tabler/icons-vue": "^3.23.0", "axios": "^1.7.8", "vue": "^3.5.13", "vue-router": "^4.5.0", @@ -699,6 +700,30 @@ "win32" ] }, + "node_modules/@tabler/icons": { + "version": "3.23.0", + "resolved": "https://registry.npmjs.org/@tabler/icons/-/icons-3.23.0.tgz", + "integrity": "sha512-Cz+X58jfRm0g/KcupXXuPw5knj671lNR054AnmLXvCjudiQBWI0wZulDDSsqDoGezvBzMTNPQtNcjLkZs82ZxQ==", + "funding": { + "type": "github", + "url": "https://github.com/sponsors/codecalm" + } + }, + "node_modules/@tabler/icons-vue": { + "version": "3.23.0", + "resolved": "https://registry.npmjs.org/@tabler/icons-vue/-/icons-vue-3.23.0.tgz", + "integrity": "sha512-py3ZSu80dIIEoSjGqv/4i+OppiMloz0kgBGSH4Px2Me16nS/kgvXxQSwiW6w3eZZM6hoDauxucioxU8tVItvjA==", + "dependencies": { + "@tabler/icons": "3.23.0" + }, + "funding": { + "type": "github", + "url": "https://github.com/sponsors/codecalm" + }, + "peerDependencies": { + "vue": ">=3.0.1" + } + }, "node_modules/@types/estree": { "version": "1.0.6", "resolved": "https://registry.npmjs.org/@types/estree/-/estree-1.0.6.tgz", diff --git a/web-frontend/package.json b/web-frontend/package.json index b4870bc6..8aeaa5e5 100644 --- a/web-frontend/package.json +++ b/web-frontend/package.json @@ -12,6 +12,7 @@ "node": "20.9.0" }, "dependencies": { + "@tabler/icons-vue": "^3.23.0", "axios": "^1.7.8", "vue": "^3.5.13", "vue-router": "^4.5.0", diff --git a/web-frontend/src/components/icons/Contact.vue b/web-frontend/src/components/icons/Contact.vue index 9f9bd291..09c21d23 100644 --- a/web-frontend/src/components/icons/Contact.vue +++ b/web-frontend/src/components/icons/Contact.vue @@ -1,17 +1,11 @@ + + diff --git a/web-frontend/src/components/icons/Facebook.vue b/web-frontend/src/components/icons/Facebook.vue index 11c154f6..c6a46536 100644 --- a/web-frontend/src/components/icons/Facebook.vue +++ b/web-frontend/src/components/icons/Facebook.vue @@ -1,16 +1,11 @@ + + diff --git a/web-frontend/src/components/icons/GitHub.vue b/web-frontend/src/components/icons/GitHub.vue index 46ebdcab..2266643e 100644 --- a/web-frontend/src/components/icons/GitHub.vue +++ b/web-frontend/src/components/icons/GitHub.vue @@ -1,16 +1,11 @@ + + diff --git a/web-frontend/src/components/icons/Instagram.vue b/web-frontend/src/components/icons/Instagram.vue index 5d469a2b..4402697b 100644 --- a/web-frontend/src/components/icons/Instagram.vue +++ b/web-frontend/src/components/icons/Instagram.vue @@ -1,18 +1,11 @@ + + diff --git a/web-frontend/src/components/icons/LinkedIn.vue b/web-frontend/src/components/icons/LinkedIn.vue index bcd00a44..ef78f46c 100644 --- a/web-frontend/src/components/icons/LinkedIn.vue +++ b/web-frontend/src/components/icons/LinkedIn.vue @@ -1,20 +1,11 @@ + + diff --git a/web-frontend/src/components/icons/X.vue b/web-frontend/src/components/icons/X.vue index 7292eb1c..1694edd5 100644 --- a/web-frontend/src/components/icons/X.vue +++ b/web-frontend/src/components/icons/X.vue @@ -1,17 +1,11 @@ + + From d97446ec24aa49f17df39a8300880a85f7015449 Mon Sep 17 00:00:00 2001 From: hwakabh Date: Mon, 2 Dec 2024 01:09:52 +0900 Subject: [PATCH 2/3] fix(ui): removed JSX syntax and used v-bind. --- web-frontend/src/components/icons/Contact.vue | 4 ++-- web-frontend/src/components/icons/Facebook.vue | 4 ++-- web-frontend/src/components/icons/GitHub.vue | 3 ++- web-frontend/src/components/icons/Instagram.vue | 4 ++-- web-frontend/src/components/icons/LinkedIn.vue | 4 ++-- web-frontend/src/components/icons/X.vue | 4 ++-- 6 files changed, 12 insertions(+), 11 deletions(-) diff --git a/web-frontend/src/components/icons/Contact.vue b/web-frontend/src/components/icons/Contact.vue index 09c21d23..62d3769e 100644 --- a/web-frontend/src/components/icons/Contact.vue +++ b/web-frontend/src/components/icons/Contact.vue @@ -4,8 +4,8 @@ import { IconMail } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/Facebook.vue b/web-frontend/src/components/icons/Facebook.vue index c6a46536..eebd2fbd 100644 --- a/web-frontend/src/components/icons/Facebook.vue +++ b/web-frontend/src/components/icons/Facebook.vue @@ -4,8 +4,8 @@ import { IconBrandFacebook } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/GitHub.vue b/web-frontend/src/components/icons/GitHub.vue index 2266643e..4a0d6dd1 100644 --- a/web-frontend/src/components/icons/GitHub.vue +++ b/web-frontend/src/components/icons/GitHub.vue @@ -4,8 +4,9 @@ import { IconBrandGithub } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/Instagram.vue b/web-frontend/src/components/icons/Instagram.vue index 4402697b..1e23269c 100644 --- a/web-frontend/src/components/icons/Instagram.vue +++ b/web-frontend/src/components/icons/Instagram.vue @@ -4,8 +4,8 @@ import { IconBrandInstagram } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/LinkedIn.vue b/web-frontend/src/components/icons/LinkedIn.vue index ef78f46c..e8e36456 100644 --- a/web-frontend/src/components/icons/LinkedIn.vue +++ b/web-frontend/src/components/icons/LinkedIn.vue @@ -4,8 +4,8 @@ import { IconBrandLinkedin } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/X.vue b/web-frontend/src/components/icons/X.vue index 1694edd5..ca0f6b0f 100644 --- a/web-frontend/src/components/icons/X.vue +++ b/web-frontend/src/components/icons/X.vue @@ -4,8 +4,8 @@ import { IconBrandX } from '@tabler/icons-vue'; From 56237dadfa34f8b24adc7d5523dd646879c884e2 Mon Sep 17 00:00:00 2001 From: hwakabh Date: Mon, 2 Dec 2024 01:12:21 +0900 Subject: [PATCH 3/3] fix(ui): removed fill props from each icon components. --- web-frontend/src/components/icons/Contact.vue | 1 - web-frontend/src/components/icons/Facebook.vue | 1 - web-frontend/src/components/icons/GitHub.vue | 2 -- web-frontend/src/components/icons/Instagram.vue | 1 - web-frontend/src/components/icons/LinkedIn.vue | 1 - web-frontend/src/components/icons/X.vue | 1 - 6 files changed, 7 deletions(-) diff --git a/web-frontend/src/components/icons/Contact.vue b/web-frontend/src/components/icons/Contact.vue index 62d3769e..b4e34076 100644 --- a/web-frontend/src/components/icons/Contact.vue +++ b/web-frontend/src/components/icons/Contact.vue @@ -5,7 +5,6 @@ import { IconMail } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/Facebook.vue b/web-frontend/src/components/icons/Facebook.vue index eebd2fbd..8ca06d23 100644 --- a/web-frontend/src/components/icons/Facebook.vue +++ b/web-frontend/src/components/icons/Facebook.vue @@ -5,7 +5,6 @@ import { IconBrandFacebook } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/GitHub.vue b/web-frontend/src/components/icons/GitHub.vue index 4a0d6dd1..0a4aef7e 100644 --- a/web-frontend/src/components/icons/GitHub.vue +++ b/web-frontend/src/components/icons/GitHub.vue @@ -5,8 +5,6 @@ import { IconBrandGithub } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/Instagram.vue b/web-frontend/src/components/icons/Instagram.vue index 1e23269c..89ce8f09 100644 --- a/web-frontend/src/components/icons/Instagram.vue +++ b/web-frontend/src/components/icons/Instagram.vue @@ -5,7 +5,6 @@ import { IconBrandInstagram } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/LinkedIn.vue b/web-frontend/src/components/icons/LinkedIn.vue index e8e36456..460cdbe3 100644 --- a/web-frontend/src/components/icons/LinkedIn.vue +++ b/web-frontend/src/components/icons/LinkedIn.vue @@ -5,7 +5,6 @@ import { IconBrandLinkedin } from '@tabler/icons-vue'; diff --git a/web-frontend/src/components/icons/X.vue b/web-frontend/src/components/icons/X.vue index ca0f6b0f..507e1cc1 100644 --- a/web-frontend/src/components/icons/X.vue +++ b/web-frontend/src/components/icons/X.vue @@ -5,7 +5,6 @@ import { IconBrandX } from '@tabler/icons-vue';