ci: replaced workflow triggers. #598
Conversation
WalkthroughThe GitHub Actions workflow for CodeQL analysis was updated to change its trigger conditions. The workflow now runs on push events to any branch instead of on pull request events. The manual trigger via Changes
Possibly related PRs
Suggested labels
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
ci
|
Seems the errors have been cleared with the changes in this PR, will merge this PR into main. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/codeql.yaml (1)
4-6: Consider narrowing the branch filter to optimize CI resources.Using a global glob (
'**') runs scans on every branch push, potentially consuming excessive minutes and generating duplicate alerts. If code scanning is only needed on primary or protected branches, restrict the patterns accordingly:-on: - push: - branches: - - '**' +on: + push: + branches: + - main + - release/*
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/codeql.yaml(1 hunks)
🔇 Additional comments (1)
.github/workflows/codeql.yaml (1)
7-7: Approve manual dispatch trigger.The
workflow_dispatchentry is unchanged and correctly allows manual execution of CodeQL analysis.
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - '**' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Critical: Verify PR scanning coverage after trigger changes.
By removing the pull_request event, you’ve disabled CodeQL scans on PRs, which prevents early security feedback for contributors. If you still need scanning during pull requests, re-add the trigger. For example:
on:
push:
branches:
- '**'
pull_request:
branches:
- '**'
workflow_dispatch:🏁 Script executed:
#!/bin/bash
# Display the first 20 lines of the CodeQL workflow to verify configured triggers
sed -n '1,20p' .github/workflows/codeql.yamlLength of output: 302
Add pull_request trigger to .github/workflows/codeql.yaml
You’ve removed the pull_request event, which means CodeQL will only run on pushes and manual dispatches—PRs won’t be scanned automatically. To restore early security feedback on pull requests, update your workflow’s triggers:
on:
push:
branches:
- '**'
+ pull_request:
+ branches:
+ - '**'
workflow_dispatch:• File: .github/workflows/codeql.yaml (lines 2–6)
• Include the pull_request block to ensure scans run on PRs as well.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| on: | |
| pull_request: | |
| push: | |
| branches: | |
| - '**' | |
| workflow_dispatch: | |
| on: | |
| push: | |
| branches: | |
| - '**' | |
| pull_request: | |
| branches: | |
| - '**' | |
| workflow_dispatch: |
|
After the merge of this PR, the issue has been cleared, and all the tooling configuration has been done properly.
|
* build(deps-dev): bump vite in /web-frontend in the non-majors group (#593) Bumps the non-majors group in /web-frontend with 1 update: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `vite` from 6.2.6 to 6.3.0 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/create-vite@6.3.0/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: non-majors ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump hwakabh/semantic-issue-action in the non-majors group (#594) Bumps the non-majors group with 1 update: [hwakabh/semantic-issue-action](https://github.com/hwakabh/semantic-issue-action). Updates `hwakabh/semantic-issue-action` from 0.5.4 to 0.5.5 - [Release notes](https://github.com/hwakabh/semantic-issue-action/releases) - [Changelog](https://github.com/hwakabh/semantic-issue-action/blob/main/CHANGELOG.md) - [Commits](hwakabh/semantic-issue-action@v0.5.4...v0.5.5) --- updated-dependencies: - dependency-name: hwakabh/semantic-issue-action dependency-version: 0.5.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: non-majors ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: removed unused assets from code bases. (#596) * ci: replaced workflow triggers. (#598) * security: fixed warnings by CodeQL (#599) * chore: fixed semicolon insertion error. * chore: fixed unused imports error. * chore(ui): updated career histories. * chore: fixed log injection error with removing lines. * chore: removed Rapid API related since it was not used any more. * fix(api): updated endpoint for health checking with Cloud Run. * chore: removed completed TODO from codes. * chore: updated swagger docs description. * chore: updated swagger docs. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue/PR link
N/A
For suppressing the following warnings in Workflow Runs, updated workflow triggers.
Also though we have not concluded this is also triggered the tool's configuration error on Security Tools, will check the issue has been resolved or not by this changes.
What does this PR do?
Describe what changes you make in your branch:
SSIA
(Optional) Additional Contexts
Describe additional information for reviewers (i.e. What does not included)
mainto confirm changes would be appliedSummary by CodeRabbit